Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new state structure and register it in InitialModServiceTokenSchema #13939

Closed
Tracked by #13113
yosiftouma opened this issue Jun 19, 2024 · 1 comment · Fixed by #13566 or #14276
Closed
Tracked by #13113

Implement new state structure and register it in InitialModServiceTokenSchema #13939

yosiftouma opened this issue Jun 19, 2024 · 1 comment · Fixed by #13566 or #14276
Assignees
Labels
Limechain Work planned for the LimeChain team
Milestone

Comments

@yosiftouma
Copy link

yosiftouma commented Jun 19, 2024

  • Understand how InitialModServiceTokenSchema works
  • Add StateDefinition.onDisk(AIRDROPS_KEY, PendingAirdropId.PROTOBUF, PendingAirdropValue.PROTOBUF, MAX__AIRDROPS); to statesToCreate
  • MAX__AIRDROPS - put it to 10_000_000_000 for now and ask in the airdrop slack channel about the correct value
  • It's possible that this change will be enough for the implementation but make sure that this is the case. It's possible that adding the state definition to statesToCreate automatically handles everything but we need to double-check that.

Note: in order to use the new protobufs use the changes from hip-904-proto-updates branch

For more context read: #12792

@yosiftouma yosiftouma linked a pull request Jun 19, 2024 that will close this issue
2 tasks
@yosiftouma yosiftouma added the Limechain Work planned for the LimeChain team label Jun 19, 2024
@yosiftouma yosiftouma added this to the v0.53 milestone Jun 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Jul 1, 2024
@netopyr netopyr moved this from 📋 Backlog to 👀 In Review in Services Team Jul 1, 2024
@vtronkov vtronkov moved this from 👀 In Review to ✅ Done in Services Team Jul 2, 2024
@vtronkov vtronkov moved this from In Review to Done in Smart Contract Sprint Board Jul 2, 2024
@vtronkov
Copy link
Contributor

vtronkov commented Jul 2, 2024

Approved and merged into the feature branch: #13566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
Archived in project
Archived in project
3 participants