docs: add design doc for pending state #12792

IvanKavaldzhiev · 2024-04-15T11:08:44Z

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-04-15T11:28:26Z

Node: HAPI Test (Restart) Results

3 tests 3 ✅ 6m 6s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T11:31:10Z

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 5m 46s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T11:43:40Z

Node: HAPI Test (Token) Results

20 files 20 suites 5m 57s ⏱️
268 tests 268 ✅ 0 💤 0 ❌
343 runs 343 ✅ 0 💤 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T12:00:55Z

Node: HAPI Test (Misc) Results

51 files 51 suites 23m 43s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs 374 ✅ 0 💤 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T12:01:39Z

Node: HAPI Test (Crypto) Results

23 files 23 suites 12m 0s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs 356 ✅ 0 💤 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T12:16:42Z

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 21m 57s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T12:28:45Z

Node: Unit Test Results

2 331 files ±0 2 331 suites ±0 2h 26m 43s ⏱️ ±0s
119 772 tests ±0 119 702 ✅ ±0 70 💤 ±0 0 ❌ ±0
128 339 runs ±0 128 269 ✅ ±0 70 💤 ±0 0 ❌ ±0

Results for commit 413e532. ± Comparison against base commit a0eb015.

This pull request removes 370 and adds 125 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=INkr4No6,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=39695,hostnameExternal=246.63.189.248,portExternalIpv4=39695,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7c52d599,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@fdacdbb,memo=7OE8bIxt],
   Address[id=3,nickname=nKdGhlxa,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=14099,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@50ccebbb, agrKeyPair=java.security.KeyPair@2bbf9ee1, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=OoAsiXjc,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=25875,hostnameExternal=155.245.249.206,portExternalIpv4=25875,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@ba27c12,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@3c7a3f0d,memo=3aCbChNe],
   Address[id=3,nickname=0bnmhMiB,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=17786,hostnameExternal…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@34910b0d, agrKeyPair=java.security.KeyPair@21d582fc, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [3] AddressBook {
   Address[id=0,nickname=Tc4tp9AN,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=52990,hostnameExternal=3.111.118.93,portExternalIpv4=52990,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@44db06d9,agreeCert=<null>,memo=rT0LmGEq],
   Address[id=2,nickname=HkyzIv95,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=21192,hostnameExternal=202.1.107.113,portExternalIpv4=21192,sigPublicKey=<null>,ag…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@645d860, agrKeyPair=java.security.KeyPair@62c25a94, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 3993597839710083868231945175919139090761808006636174301522933223628513549165622405392179927490525437989266705657795380522223992433641724878847443931065713607200936674817049095003247060840820816825608104539722939764219883909214899161…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=Jh5vCseb,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=33246,hostnameExternal=179.6.169.97,portExternalIpv4=33246,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@5a953749,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@1074adbd,memo=BMZTrExH],
   Address[id=2,nickname=ln1EUqGN,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=53242,hostnameExternal=1…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@7afbf85c, agrKeyPair=java.security.KeyPair@5ab5a3e2, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
…

♻️ This comment has been updated with latest results.

github-actions · 2024-04-15T12:33:17Z

Node: HAPI Test (Smart Contract) Results

71 files 71 suites 23m 42s ⏱️
604 tests 604 ✅ 0 💤 0 ❌
656 runs 656 ✅ 0 💤 0 ❌

Results for commit 413e532.

♻️ This comment has been updated with latest results.

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md

…ate-design

Signed-off-by: IvanKavaldzhiev <[email protected]>

Neeharika-Sompalli

LGTM!

…ate-design

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

netopyr

LGTM - thanks @IvanKavaldzhiev

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md

Signed-off-by: IvanKavaldzhiev <[email protected]>

…ate-design

codecov · 2024-06-04T10:25:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (a0eb015) to head (6a6a9c5).
Report is 1 commits behind head on develop.

❗ Current head 6a6a9c5 differs from pull request most recent head 413e532

Please upload reports for the commit 413e532 to get more accurate results.

Additional details and impacted files

@@              Coverage Diff               @@
##             develop   #12792       +/-   ##
==============================================
+ Coverage           0   67.56%   +67.56%     
- Complexity         0    36383    +36383     
==============================================
  Files              0     3715     +3715     
  Lines              0   149454   +149454     
  Branches           0    15560    +15560     
==============================================
+ Hits               0   100986   +100986     
- Misses             0    44099    +44099     
- Partials           0     4369     +4369

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mustafauzunn

LGTM

netopyr

LGTM - thanks @IvanKavaldzhiev

…into hip-904-pending-state-design

IvanKavaldzhiev added Limechain Work planned for the LimeChain team Design Issue/PR for feature design documents. labels Apr 15, 2024

IvanKavaldzhiev requested review from rbair23, tinker-michaelj and Neeharika-Sompalli April 15, 2024 11:08

IvanKavaldzhiev self-assigned this Apr 15, 2024

IvanKavaldzhiev requested a review from a team April 15, 2024 11:08

IvanKavaldzhiev requested a review from a team as a code owner April 15, 2024 11:08

IvanKavaldzhiev requested a review from iwsimon April 15, 2024 11:08

IvanKavaldzhiev changed the title ~~HIP-904: Add design doc for pending state~~ HIP-904: Add design doc for airdrop pending state Apr 15, 2024

IvanKavaldzhiev changed the title ~~HIP-904: Add design doc for airdrop pending state~~ feat: add design doc for pending state Apr 15, 2024

doc: add design doc for pending state

451759a

Signed-off-by: IvanKavaldzhiev <[email protected]>

IvanKavaldzhiev force-pushed the hip-904-pending-state-design branch from 21ea55d to 451759a Compare April 15, 2024 13:16

IvanKavaldzhiev changed the title ~~feat: add design doc for pending state~~ doc: add design doc for pending state Apr 15, 2024

IvanKavaldzhiev added 2 commits April 17, 2024 17:13

refactor: clean up design and remove handleAidrop from writable store

ef15989

Signed-off-by: IvanKavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

abbf34e

…ate-design

IvanKavaldzhiev changed the title ~~doc: add design doc for pending state~~ docs: add design doc for pending state Apr 17, 2024

Nana-EC reviewed Apr 19, 2024

View reviewed changes

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Outdated Show resolved Hide resolved

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Apr 22, 2024

View reviewed changes

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Outdated Show resolved Hide resolved

IvanKavaldzhiev added 2 commits April 23, 2024 09:37

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

6055736

…ate-design

nit: resolve PR comments

8c1f4f6

Signed-off-by: IvanKavaldzhiev <[email protected]>

Neeharika-Sompalli previously approved these changes Apr 25, 2024

View reviewed changes

IvanKavaldzhiev added 5 commits May 23, 2024 15:03

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

3ee3861

…ate-design

nit: resolve PR comments

2c36d61

Signed-off-by: IvanKavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

c952a3b

…ate-design

nit: resolve PR comments

e08d0e5

Signed-off-by: IvanKavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

1427f23

…ate-design

vtronkov reviewed May 29, 2024

View reviewed changes

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Outdated Show resolved Hide resolved

IvanKavaldzhiev added 6 commits May 29, 2024 09:23

nit: fix typo

9383fab

Signed-off-by: IvanKavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

4910f6c

…ate-design

nit: fix typo

9fdb248

Signed-off-by: IvanKavaldzhiev <[email protected]>

nit: add additional protobuf field for AccountAirdrop

b0b7ab1

Signed-off-by: IvanKavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

83f1ec9

…ate-design

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

62350c5

…ate-design

netopyr previously approved these changes May 31, 2024

View reviewed changes

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Outdated Show resolved Hide resolved

hedera-node/docs/design/services/token-service/airdrops/airdrop-pending-state.md Show resolved Hide resolved

nit: fix typo

c695207

Signed-off-by: IvanKavaldzhiev <[email protected]>

IvanKavaldzhiev dismissed netopyr’s stale review via c695207 May 31, 2024 13:44

IvanKavaldzhiev added 4 commits May 31, 2024 16:46

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

359234a

…ate-design

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

b2ea9a7

…ate-design

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

0569008

…ate-design

Merge remote-tracking branch 'origin/develop' into hip-904-pending-st…

6a6a9c5

…ate-design

mustafauzunn approved these changes Jun 4, 2024

View reviewed changes

netopyr approved these changes Jun 4, 2024

View reviewed changes

netopyr added this to the v0.52 milestone Jun 4, 2024

netopyr added Pending Triage New issue that needs to be triaged by the team. and removed Pending Triage New issue that needs to be triaged by the team. labels Jun 4, 2024

Merge branch 'develop' of https://github.com/hashgraph/hedera-services …

413e532

…into hip-904-pending-state-design

IvanKavaldzhiev merged commit af2a141 into develop Jun 7, 2024
45 of 46 checks passed

IvanKavaldzhiev deleted the hip-904-pending-state-design branch June 7, 2024 20:19

This was referenced Jun 19, 2024

Define ReadableAirdropStore and WritableAirdropStore interfaces and provide implementations for them #13938

Closed

Implement new state structure and register it in InitialModServiceTokenSchema #13939

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add design doc for pending state #12792

docs: add design doc for pending state #12792

IvanKavaldzhiev commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

Neeharika-Sompalli left a comment

netopyr left a comment

codecov bot commented Jun 4, 2024 •

edited

Loading

mustafauzunn left a comment

netopyr left a comment

docs: add design doc for pending state #12792

docs: add design doc for pending state #12792

Conversation

IvanKavaldzhiev commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented Apr 15, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

netopyr left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 4, 2024 • edited Loading

Codecov Report

mustafauzunn left a comment

Choose a reason for hiding this comment

netopyr left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

codecov bot commented Jun 4, 2024 •

edited

Loading