Hip 904 proto updates #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jsync-swirlds
previously approved these changes
Jul 22, 2024
vtronkov
force-pushed
the
hip-904-proto-updates
branch
from
47d111d to
af0df3f
Compare
vtronkov
dismissed stale reviews from jsync-swirlds, edwin-greene, and Neeharika-Sompalli
via
16c1f00
vtronkov
force-pushed
the
hip-904-proto-updates
branch
from
af0df3f to
16c1f00
Compare
* added consensus data protobuf Signed-off-by: Lazar Petrovic <[email protected]> * Update platform/event/event_consensus_data.proto Co-authored-by: Joseph Sinclair <[email protected]> --------- Signed-off-by: Lazar Petrovic <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
feat: maxAutoAssociations updates Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
added NodeGetInfoResponse to response.proto Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
….51 (#358) * Revert "feat: added NodeGetInfoResponse to response.proto (#355)" This reverts commit 43d9159. * Revert "Added NodeGetInfo (#347)" This reverts commit 17fb148. * Revert "feat: Dynamic Address Book Phase 2 protobufs changes (#344)" This reverts commit e650477 as hedera-servives #13265 asked. Signed-off-by: Iris Simon <[email protected]> * Align the code. Signed-off-by: Iris Simon <[email protected]> * Changed INVALID_MAX_AUTO_ASSOCIATIONS back to 346 by review request. Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* added deleted in node.proto Signed-off-by: Iris Simon <[email protected]> * Added MAX_NODE_HAVE_BEEN_CREATED Signed-off-by: Iris Simon <[email protected]> * updated comments with latest FQDN meeting. Signed-off-by: Iris Simon <[email protected]> * added more response code Signed-off-by: Iris Simon <[email protected]> * added more response code Signed-off-by: Iris Simon <[email protected]> * Revert "feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)" This reverts commit 6096d43 Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* updated response codes Signed-off-by: Iris Simon <[email protected]> * updated name Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
chore: add status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
* add more response code Signed-off-by: Iris Simon <[email protected]> * updated to avoid conflict with HIP 904 changes. Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]>
Update specification text for address book service
* Updated specification/API comments
* Consolidated review changes
* Adjusted wording for consistency and clarity
* Adjusted formatting for consistency
* Updated query.proto with package changes
* Corrected gossip certificate encoding
* Adjusted gossip endpoint to state that networks may or
may not require those endpoints to have or not have
a DNS entry.
* Further clarified that DNS vs. Address is network-specific.
* Matched updated wording based on recent discussions
* Removed references to status in state Node message.
* Removed status enum as requested.
* Added deleted flag to match recent updates.
Signed-off-by: Joseph Sinclair <[email protected]>
Fixing single-letter mismatch to expectations Signed-off-by: Joseph Sinclair <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Remove node_get_info.proto Signed-off-by: Iris Simon <[email protected]>
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
chore: add status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* Updated codeowners to include devops-ci Signed-off-by: Roger Barker <[email protected]> * fixed whitespace Signed-off-by: Roger Barker <[email protected]> --------- Signed-off-by: Roger Barker <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
…proto (#380) * Add admin_key to node_create.proto, node_update.proto and node.proto Signed-off-by: Iris Simon <[email protected]> * Updated changes. Signed-off-by: Iris Simon <[email protected]> * Updated changes. Signed-off-by: Iris Simon <[email protected]> * Updated with review comments. Signed-off-by: Iris Simon <[email protected]> * Updated with review comments. Signed-off-by: Iris Simon <[email protected]> * Removed getNodeInfo from address_book_service.proto Signed-off-by: Iris Simon <[email protected]> * Updated with review comments. Signed-off-by: Iris Simon <[email protected]> * Updated with review comments. Signed-off-by: Iris Simon <[email protected]> * Added UPDATE_NODE_ACCOUNT_NOT_ALLOWED Signed-off-by: Iris Simon <[email protected]> * updated Signed-off-by: Iris Simon <[email protected]> * fixed indentation Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Token Airdrop Proto changes Signed-off-by: ibankov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* Token Airdrop Proto changes Signed-off-by: ibankov <[email protected]> Signed-off-by: Stanimir Stoyanov <[email protected]> * feat: add TokenCancelAirdrop transaction Signed-off-by: Stanimir Stoyanov <[email protected]> * fix: remove PendingAirdrop def from CancelAirdrop proto Signed-off-by: Stanimir Stoyanov <[email protected]> * feat: add new response codes for cancel airdrop Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Stanimir Stoyanov <[email protected]> * chore: address pr comments Signed-off-by: Stanimir Stoyanov <[email protected]> * chore: replace line break Signed-off-by: Stanimir Stoyanov <[email protected]> * feat: add response for exceeding max pending airdrops Signed-off-by: Stanimir Stoyanov <[email protected]> --------- Signed-off-by: ibankov <[email protected]> Signed-off-by: Stanimir Stoyanov <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Co-authored-by: ibankov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* Change package to proto Signed-off-by: Iris Simon <[email protected]> * Change AddressBookService to package proto. Signed-off-by: Iris Simon <[email protected]> * Revert "Change package to proto" This reverts commit df441ef. * Change AddressBookService to package proto. Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* feat: 13135 Added PlatformState protobuf representation Signed-off-by: Ivan Malygin <[email protected]> * Update sdk/platform_state.proto Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> * Moved platform_state.proto to platform/state directory. Updated the documentation according to the guidelines. Moved platform_state.proto to platform/state directory. Updated the documentation according to the guidelines. Signed-off-by: Ivan Malygin <[email protected]> * Updated type of `lowest_judge_generation_before_birth_round_mode` to int64 as it can be negative. Signed-off-by: Ivan Malygin <[email protected]> * Added platform-specific `AddressBook`. Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> * Addressed review comments. Signed-off-by: Ivan Malygin <[email protected]> * Removed Roster, Address and NodeId as they will be a part of another PR. Fixed `PlatformState` indices. Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> * Addressed review comments: Added `deprecated` tag amd changed the type of `last_round_before_birth_round_mode` and `lowest_judge_generation_before_birth_round_mode` to `uint64` Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> * Addressed review comments - removed `SoftwareVersion` message and replaced it with `SemanticVersion` Signed-off-by: Ivan Malygin <[email protected]> * Addressed a review comment - deprecated `last_round_before_birth_round_mode` and updated its order. Signed-off-by: Ivan Malygin <[email protected]> * Addressed a review comment - improved description for `minimum_judge_ancient_threshold`. Signed-off-by: Ivan Malygin <[email protected]> * Addressed a review comment - removed `round` and `consensusTimestamp` from `ConsensusSnapshot`, as these fields duplicate fields in `PlatformState` and mean exactly the same thing. Signed-off-by: Ivan Malygin <[email protected]> * Addressed a review comment - updated comment for `MinimumJudgeInfo` Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> * Addressed Lazar's comment - removed `round` from `PlatformState` and put it back to `ConsensusSnapshot` Signed-off-by: Ivan Malygin <[email protected]> * Addressed Lazar's comment - removed `consensus_timestamp` from `PlatformState` and put it back to `ConsensusSnapshot` Signed-off-by: Ivan Malygin <[email protected]> * Improved javadoc for `ConsensusSnapshot.consensus_timestamp` Signed-off-by: Ivan Malygin <[email protected]> * Addressed Cody's comment - moved `PlatformState.first_version_in_birth_round_mode` to the set of deprecated fields. Signed-off-by: Ivan Malygin <[email protected]> * Fixed HTML tags. Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> --------- Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: Joseph Sinclair <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* feat: 14294 Add `AddressBook` to `PlatformState` Signed-off-by: Ivan Malygin <[email protected]> * Added missing newline at EOF Signed-off-by: Ivan Malygin <[email protected]> * Removed unnecessary comment. Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> --------- Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: kfa-aguda <[email protected]> Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* feat: HIP-904 account changes Signed-off-by: ibankov <[email protected]> * add account id to account_airdrop.proto Signed-off-by: ibankov <[email protected]> * Refactor account_airdrop.proto Signed-off-by: ibankov <[email protected]> * Change Airdrop record value Signed-off-by: ibankov <[email protected]> * Doc fixes Signed-off-by: ibankov <[email protected]> * Reverting airdrop record to use pending airdrop value Signed-off-by: ibankov <[email protected]> * Addressing comments Signed-off-by: ibankov <[email protected]> * Fixing numeration Signed-off-by: ibankov <[email protected]> --------- Signed-off-by: ibankov <[email protected]> Co-authored-by: Valentin Tronkov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* feat: HIP-904 account changes Signed-off-by: ibankov <[email protected]> * add account id to account_airdrop.proto Signed-off-by: ibankov <[email protected]> * Refactor account_airdrop.proto Signed-off-by: ibankov <[email protected]> * Change Airdrop record value Signed-off-by: ibankov <[email protected]> * Doc fixes Signed-off-by: ibankov <[email protected]> * Reverting airdrop record to use pending airdrop value Signed-off-by: ibankov <[email protected]> * feat: add airdrop claim protos Signed-off-by: Valentin Tronkov <[email protected]> * Update services/basic_types.proto layout Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]> * Update services/basic_types.proto layout Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]> * Update services/token_service.proto layout Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]> * feat: add token claim functionality enum Signed-off-by: Valentin Tronkov <[email protected]> * feat: add TokenClaimAirdropTransactionBody to transaction body proto Signed-off-by: Valentin Tronkov <[email protected]> * refactor: move token claim airdrop to a separate file Signed-off-by: Valentin Tronkov <[email protected]> * fix: import the claim proto into transaction body proto Signed-off-by: Valentin Tronkov <[email protected]> * feat: add token claim body in the scheduled transaction body proto Signed-off-by: Valentin Tronkov <[email protected]> * feat: add token airdrop body in the scheduled transaction body proto Signed-off-by: Valentin Tronkov <[email protected]> * nit: add empty lines at the end of the files Signed-off-by: Valentin Tronkov <[email protected]> * Addressing comments Signed-off-by: ibankov <[email protected]> * Fixing numeration Signed-off-by: ibankov <[email protected]> --------- Signed-off-by: ibankov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]> Co-authored-by: ibankov <[email protected]> Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <[email protected]> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <[email protected]> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <[email protected]> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]>
Added ResponseCodeEnum value for TOKEN_HAS_NO_METADATA_OR_SUPPLY_KEY Signed-off-by: Derek Riley <[email protected]>
vtronkov
force-pushed
the
hip-904-proto-updates
branch
from
3314ff9 to
928e971
Compare
# Conflicts: # services/basic_types.proto # services/response_code.proto # services/schedulable_transaction_body.proto # services/token_service.proto # services/transaction_body.proto
Signed-off-by: ibankov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hip 904 proto updates for v0.53
Related issue(s):
hashgraph/hedera-services#13698
Fixes #
hashgraph/hedera-services#13698
Notes for reviewer:
Merge after this PR is merged into hip-904-proto-updates
Checklist