Added NodeGetInfo #347
Merged
Added NodeGetInfo #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iris Simon <[email protected]>
Signed-off-by: Iris Simon <[email protected]>
jsync-swirlds
previously approved these changes
May 6, 2024
Signed-off-by: Iris Simon <[email protected]>
jsync-swirlds
approved these changes
May 6, 2024
jsync-swirlds
approved these changes
May 7, 2024
Neeharika-Sompalli
approved these changes
May 7, 2024
steven-sheehy
approved these changes
May 7, 2024
iwsimon
added a commit
that referenced
this pull request
May 29, 2024
….51 (#358) * Revert "feat: added NodeGetInfoResponse to response.proto (#355)" This reverts commit 43d9159. * Revert "Added NodeGetInfo (#347)" This reverts commit 17fb148. * Revert "feat: Dynamic Address Book Phase 2 protobufs changes (#344)" This reverts commit e650477 as hedera-servives #13265 asked. Signed-off-by: Iris Simon <[email protected]> * Align the code. Signed-off-by: Iris Simon <[email protected]> * Changed INVALID_MAX_AUTO_ASSOCIATIONS back to 346 by review request. Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]>
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ... # Conflicts: # services/basic_types.proto # services/schedulable_transaction_body.proto # services/token_service.proto # services/transaction_body.proto # services/transaction_receipt.proto
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ...
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
….51 (#358) * Revert "feat: added NodeGetInfoResponse to response.proto (#355)" This reverts commit 43d9159. * Revert "Added NodeGetInfo (#347)" This reverts commit 17fb148. * Revert "feat: Dynamic Address Book Phase 2 protobufs changes (#344)" This reverts commit e650477 as hedera-servives #13265 asked. Signed-off-by: Iris Simon <[email protected]> * Align the code. Signed-off-by: Iris Simon <[email protected]> * Changed INVALID_MAX_AUTO_ASSOCIATIONS back to 346 by review request. Signed-off-by: Iris Simon <[email protected]> --------- Signed-off-by: Iris Simon <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added NodeGetInfo to HederaFunctionality, added NodeGetInfoQuery to query.proto
Related issue(s):
Fixes #
Notes for reviewer:
Checklist