-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TokenRejectTransactionBody to transaction_body proto #354
Merged
jsync-swirlds
merged 3 commits into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-token-reject-transaction-body
May 21, 2024
Merged
feat: add TokenRejectTransactionBody to transaction_body proto #354
jsync-swirlds
merged 3 commits into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-token-reject-transaction-body
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Valkanov <[email protected]>
MrValioBg
requested review from
derektriley and
jascks
and removed request for
a team
May 17, 2024 09:03
Signed-off-by: Valentin Valkanov <[email protected]>
Neeharika-Sompalli
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Valentin Valkanov <[email protected]>
jsync-swirlds
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jsync-swirlds
merged commit May 21, 2024
0a2bee4
into
hashgraph:hip-904-proto-updates
1 check passed
jsync-swirlds
pushed a commit
that referenced
this pull request
Jun 5, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]>
MiroslavGatsanoga
pushed a commit
to LimeChain/hedera-protobufs
that referenced
this pull request
Jun 6, 2024
…raph#354) Signed-off-by: Valentin Valkanov <[email protected]>
MiroslavGatsanoga
pushed a commit
to LimeChain/hedera-protobufs
that referenced
this pull request
Jun 6, 2024
…raph#354) Signed-off-by: Valentin Valkanov <[email protected]>
MiroslavGatsanoga
pushed a commit
to LimeChain/hedera-protobufs
that referenced
this pull request
Jun 6, 2024
…raph#354) Signed-off-by: Valentin Valkanov <[email protected]>
jsync-swirlds
pushed a commit
that referenced
this pull request
Jun 24, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]>
jsync-swirlds
pushed a commit
that referenced
this pull request
Jun 24, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]>
Neeharika-Sompalli
pushed a commit
that referenced
this pull request
Jun 27, 2024
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <[email protected]> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <[email protected]> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <[email protected]> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto Signed-off-by: Valentin Valkanov <[email protected]> * feat: improve comment docs and add it to schedulable_transaction_body Signed-off-by: Valentin Valkanov <[email protected]> * chore: fix comments Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Valentin Valkanov <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <[email protected]> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <[email protected]> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <[email protected]> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <[email protected]> --------- Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Signed-off-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]> Co-authored-by: Valentin Valkanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds missing TokenRejectTransactionBody to transaction_body proto
Related issue(s):
Fixes #
Notes for reviewer:
Checklist