Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TokenRejectTransactionBody to transaction_body proto #354

Conversation

MrValioBg
Copy link
Contributor

Description:
This PR adds missing TokenRejectTransactionBody to transaction_body proto

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MrValioBg MrValioBg requested review from a team as code owners May 17, 2024 09:03
@MrValioBg MrValioBg requested review from derektriley and jascks and removed request for a team May 17, 2024 09:03
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Valentin Valkanov <[email protected]>
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsync-swirlds jsync-swirlds merged commit 0a2bee4 into hashgraph:hip-904-proto-updates May 21, 2024
1 check passed
jsync-swirlds pushed a commit that referenced this pull request Jun 5, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: improve comment docs and add it to schedulable_transaction_body

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: fix comments

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Valentin Valkanov <[email protected]>
MiroslavGatsanoga pushed a commit to LimeChain/hedera-protobufs that referenced this pull request Jun 6, 2024
MiroslavGatsanoga pushed a commit to LimeChain/hedera-protobufs that referenced this pull request Jun 6, 2024
MiroslavGatsanoga pushed a commit to LimeChain/hedera-protobufs that referenced this pull request Jun 6, 2024
jsync-swirlds pushed a commit that referenced this pull request Jun 24, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: improve comment docs and add it to schedulable_transaction_body

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: fix comments

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Valentin Valkanov <[email protected]>
jsync-swirlds pushed a commit that referenced this pull request Jun 24, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: improve comment docs and add it to schedulable_transaction_body

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: fix comments

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Valentin Valkanov <[email protected]>
Neeharika-Sompalli pushed a commit that referenced this pull request Jun 27, 2024
* feat: add token reject transaction (#351)

Signed-off-by: Miroslav Gatsanoga <[email protected]>

* feat: add TokenRejectTransactionBody to transaction_body proto (#354)

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: maxAutoAssociations updates for contract transactions (#359)

Signed-off-by: Miroslav Gatsanoga <[email protected]>

* chore: add status code tokenreject

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: add empty-reference status code tokenreject

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Valentin Valkanov <[email protected]>
Signed-off-by: Valentin Valkanov <[email protected]>
Co-authored-by: Valentin Valkanov <[email protected]>
Co-authored-by: Valentin Valkanov <[email protected]>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: improve comment docs and add it to schedulable_transaction_body

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: fix comments

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Valentin Valkanov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
* feat: add TokenRejectTransactionBody to transaction_body.proto

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: improve comment docs and add it to schedulable_transaction_body

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: fix comments

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Valentin Valkanov <[email protected]>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
* feat: add token reject transaction (#351)

Signed-off-by: Miroslav Gatsanoga <[email protected]>

* feat: add TokenRejectTransactionBody to transaction_body proto (#354)

Signed-off-by: Valentin Valkanov <[email protected]>

* feat: maxAutoAssociations updates for contract transactions (#359)

Signed-off-by: Miroslav Gatsanoga <[email protected]>

* chore: add status code tokenreject

Signed-off-by: Valentin Valkanov <[email protected]>

* chore: add empty-reference status code tokenreject

Signed-off-by: Valentin Valkanov <[email protected]>

---------

Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Valentin Valkanov <[email protected]>
Signed-off-by: Valentin Valkanov <[email protected]>
Co-authored-by: Valentin Valkanov <[email protected]>
Co-authored-by: Valentin Valkanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants