feat: 14294 Add AddressBook to PlatformState
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
kfa-aguda
reviewed
Jul 18, 2024
Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]>
Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Ivan Malygin <[email protected]>
jsync-swirlds
approved these changes
Jul 18, 2024
kfa-aguda
approved these changes
Jul 18, 2024
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: 14294 Add `AddressBook` to `PlatformState` Signed-off-by: Ivan Malygin <[email protected]> * Added missing newline at EOF Signed-off-by: Ivan Malygin <[email protected]> * Removed unnecessary comment. Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> --------- Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: kfa-aguda <[email protected]> Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: 14294 Add `AddressBook` to `PlatformState` Signed-off-by: Ivan Malygin <[email protected]> * Added missing newline at EOF Signed-off-by: Ivan Malygin <[email protected]> * Removed unnecessary comment. Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: kfa-aguda <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> * Update platform/state/platform_state.proto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Ivan Malygin <[email protected]> --------- Signed-off-by: Ivan Malygin <[email protected]> Co-authored-by: kfa-aguda <[email protected]> Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds two fields to
PlatformStateobject. This is a temporary solution that should be sunsetted once TSS Roster (hashgraph/hedera-services#14045) is implemented. In fact, the migration fromAddressBooktoRosterobjects should be a part of this design.Important: The implementation of the
AddressBookis not optimized and reflects exactlycom.swirlds.platform.system.address.AddressBookand its components. This implementation will be sunsetted before we launch block streams, and therefore there is no need in optimizing it.Related issue(s):
Fixes # hashgraph/hedera-services#14294
Notes for reviewer:
Checklist