Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TSS Rosters design proposal #14045

Merged
merged 57 commits into from
Aug 12, 2024
Merged

Conversation

kfa-aguda
Copy link
Contributor

@kfa-aguda kfa-aguda commented Jun 25, 2024

Description:

This design doc provides the specification for Rosters - a new Data Structure introduced for enabling the Threshold Signature Scheme. The proposal details the data structure and lifecycle of Rosters, as well as the changes needed from Services and DevOps.

fixes #13893

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 29s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: Unit Test Results

  1 559 files    1 559 suites   2h 56m 50s ⏱️
117 917 tests 117 858 ✅ 59 💤 0 ❌
126 131 runs  126 072 ✅ 59 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Token) Results

 22 files   22 suites   5m 42s ⏱️
281 tests 281 ✅ 0 💤 0 ❌
364 runs  364 ✅ 0 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  4m 50s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.73%. Comparing base (9973fae) to head (a35da8f).
Report is 230 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #14045      +/-   ##
=============================================
- Coverage      67.58%   57.73%   -9.86%     
+ Complexity     36486    21991   -14495     
=============================================
  Files           3732     2885     -847     
  Lines         149767   110609   -39158     
  Branches       15571    11305    -4266     
=============================================
- Hits          101223    63858   -37365     
+ Misses         44179    43139    -1040     
+ Partials        4365     3612     -753     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Crypto) Results

 32 files   32 suites   12m 18s ⏱️
364 tests 364 ✅ 0 💤 0 ❌
395 runs  395 ✅ 0 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Misc) Results

 61 files   61 suites   15m 46s ⏱️
319 tests 319 ✅ 0 💤 0 ❌
409 runs  409 ✅ 0 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 59s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 25, 2024

Node: HAPI Test (Smart Contract) Results

 92 files   92 suites   26m 32s ⏱️
660 tests 660 ✅ 0 💤 0 ❌
872 runs  872 ✅ 0 💤 0 ❌

Results for commit 355ab72.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edward-swirldslabs edward-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.20% approval so far. Lots of work left. :-)

@kfa-aguda kfa-aguda requested a review from netopyr August 7, 2024 22:27
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

kfa-aguda and others added 2 commits August 12, 2024 10:54
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Signed-off-by: Kore Aguda <[email protected]>
Signed-off-by: Kore Aguda <[email protected]>
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kfa-aguda kfa-aguda merged commit 2c03192 into develop Aug 12, 2024
45 of 46 checks passed
@kfa-aguda kfa-aguda deleted the 13775-tss-rosters-design-proposal branch August 12, 2024 19:56
HarshSawarkar pushed a commit to HarshSawarkar/hedera-services that referenced this pull request Aug 23, 2024
Signed-off-by: Kore Aguda <[email protected]>
Signed-off-by: Anthony Petrov <[email protected]>
Signed-off-by: kfa-aguda <[email protected]>
Co-authored-by: Anthony Petrov <[email protected]>
Co-authored-by: Kelly Greco <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
stoyanov-st pushed a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Kore Aguda <[email protected]>
Signed-off-by: Anthony Petrov <[email protected]>
Signed-off-by: kfa-aguda <[email protected]>
Co-authored-by: Anthony Petrov <[email protected]>
Co-authored-by: Kelly Greco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Accepted
Development

Successfully merging this pull request may close these issues.

Create a draft design proposal for the Roster portion of the TSS Block Signing project