Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize and re-enable feature importance tests #117503

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 4, 2021

Summary

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.

Closes #116078

@pheyos pheyos self-assigned this Nov 4, 2021
@pheyos pheyos requested a review from a team as a code owner November 4, 2021 12:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Nov 4, 2021

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@qn895
Copy link
Member

qn895 commented Nov 4, 2021

Changes LGTM 🎉

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit d0567f8 into elastic:main Nov 5, 2021
@pheyos pheyos deleted the stabilize_feature_importance_tests branch November 5, 2021 09:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
…sts (elastic#117503)

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
…sts (elastic#117503)

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
kibanamachine added a commit that referenced this pull request Nov 5, 2021
…sts (#117503) (#117625)

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.

Co-authored-by: Robert Oskamp <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 5, 2021
…sts (#117503) (#117626)

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.16.0 v8.0.0 v8.1.0
Projects
None yet
5 participants