Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert #114917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ymao1
commented
Oct 14, 2021
| interval: '1m', | ||
| }, | ||
| ]); | ||
| const searchResultAfterSave = searchResultsAfterSave[0]; |
There was a problem hiding this comment.
These tests should have been updated with this PR but were missed since this test suite was skipped at the time.
ymao1
commented
Oct 14, 2021
| await testSubjects.click('confirmAlertCloseModal > confirmModalConfirmButton'); | ||
| }); | ||
|
|
||
| it('should show error when es_query is invalid', async () => { |
There was a problem hiding this comment.
This is the test that I split into 2 tests.
ymao1
changed the title
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
ymao1
added
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…nctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) * Unskipping test * Commenting out fix and fixing another test * Fixing functional test * Fixing functional test agaaaiiinn * Fixing the actual flake * Splitting into two tests * Maybe this time
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…nctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) * Unskipping test * Commenting out fix and fixing another test * Fixing functional test * Fixing functional test agaaaiiinn * Fixing the actual flake * Splitting into two tests * Maybe this time
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…nctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (#114917) (#117566) * Unskipping test * Commenting out fix and fixing another test * Fixing functional test * Fixing functional test agaaaiiinn * Fixing the actual flake * Splitting into two tests * Maybe this time Co-authored-by: ymao1 <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…nctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (#114917) (#117569) * Unskipping test * Commenting out fix and fixing another test * Fixing functional test * Fixing functional test agaaaiiinn * Fixing the actual flake * Splitting into two tests * Maybe this time Co-authored-by: ymao1 <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 5, 2021
…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #112749
Summary
Was able to recreate the flakiness using the buildkite flaky test runner. Ended up splitting one test that was testing 2 things into 2 tests.
Flaky test runs (looks like there are some other flaky tests in the ci group, but this suite ran successfully):