[Metrics UI] Add docs link to redundant groupBy detection #116822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:fix
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
lukeelmers
approved these changes
Nov 1, 2021
Zacqary
changed the title
neptunian
reviewed
Nov 1, 2021
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
Outdated
Show resolved
Hide resolved
…ts/expression.tsx Co-authored-by: Sandra G <[email protected]>
neptunian
approved these changes
Nov 2, 2021
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…6822) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <[email protected]> Co-authored-by: Sandra G <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…6822) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <[email protected]> Co-authored-by: Sandra G <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…117563) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <[email protected]> Co-authored-by: Sandra G <[email protected]> Co-authored-by: Zacqary Adam Xeper <[email protected]> Co-authored-by: Sandra G <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…117564) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <[email protected]> Co-authored-by: Sandra G <[email protected]> Co-authored-by: Zacqary Adam Xeper <[email protected]> Co-authored-by: Sandra G <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 5, 2021
…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDO OF #116695 which was accidentally merged before approval
Summary
Fixes #116195
UPDATE
Instead of changing the logic, this PR will now add a docs link explaining how filtering and groupBy works.
Depends on this docs PR: elastic/observability-docs#1196
Previous Summary
In this PR,host.namewill still be flagged as redundant in this case:But with these changes, it will NOT be flagged in this case: