[Fleet] Fix agent logs not reading query from URL #117286
Conversation
hop-dev
added
release_note:fix
v8.0.0
auto-backport
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| @@ -63,7 +63,7 @@ export const createKbnUrlStateStorage = ( | |||
| onGetError, | |||
| onSetError, | |||
| }: { | |||
| useHash: boolean; | |||
| useHash?: boolean; | |||
There was a problem hiding this comment.
This param is defaulted so I believe can be set as optional?
There was a problem hiding this comment.
Probably a viable change, but if code owner review becomes a blocker maybe we should consider reverting and landing the other small change.
There was a problem hiding this comment.
I'm not 100% sure why this was marked as required at the time, perhaps it is because this functionality was "experimental" and is often tied to an advanced setting, e.g.:
useHash: coreStart.uiSettings.get('state:storeInSessionStorage')and the default would one day change.
@Dosant can confirm when is back next week. This looks like a safe change to make though, but I would advise waiting until he gets back next week or unblocking by not making this change now per @kpollich .
There was a problem hiding this comment.
Brill thanks @jloleysens I'll work around it for now 👍
| @@ -63,7 +63,7 @@ export const createKbnUrlStateStorage = ( | |||
| onGetError, | |||
| onSetError, | |||
| }: { | |||
| useHash: boolean; | |||
| useHash?: boolean; | |||
There was a problem hiding this comment.
Probably a viable change, but if code owner review becomes a blocker maybe we should consider reverting and landing the other small change.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
* Don't use hash for agent logs url state * revert core app services change
* Don't use hash for agent logs url state * revert core app services change
* Don't use hash for agent logs url state * revert core app services change Co-authored-by: Mark Hopkin <[email protected]>
…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…117568) * [Fleet] Fix agent logs not reading query from URL (#117286) * Don't use hash for agent logs url state * revert core app services change * Cherrypick changes from PR #115192 Backport @miltonhultgren's changes to add the `useHashQuery` param to `createKbnUrlStateStorage` Co-authored-by: Milton Hultgren <[email protected]> Co-authored-by: Mark Hopkin <[email protected]> Co-authored-by: Milton Hultgren <[email protected]>
kibanamachine
removed
the
backport missing
Summary
Fixes #112412
In #106267 we converted Fleet routing to not use hashes. We then moved to not reading the agent logs state from the URL hash in #109982 but the URL state storage connector was still storing the query using the hash, causing a mismatch.