Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors][ServiceNow] Remove SN flags #117511

Merged
merged 4 commits into from
Nov 5, 2021
Merged

[Connectors][ServiceNow] Remove SN flags #117511

merged 4 commits into from
Nov 5, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Nov 4, 2021 •
edited
Loading

Summary

This PR removes all ServiceNow related feature flags.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas self-assigned this Nov 4, 2021
@cnasikas cnasikas requested review from a team as code owners November 4, 2021 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Nov 4, 2021
YulNaumenko
YulNaumenko approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

semd
semd approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested ServiceNow connectors locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 342 341 -1
securitySolution 2751 2750 -1
triggersActionsUi 329 328 -1
total -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 310.2KB 324.3KB +14.1KB
triggersActionsUi 776.8KB 776.7KB -92.0B
total +14.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 80.2KB 80.2KB -30.0B
securitySolution 252.9KB 252.9KB -9.0B
triggersActionsUi 51.6KB 51.4KB -170.0B
total -209.0B
Unknown metric groups

async chunk count

id before after diff
cases 16 15 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 5, 2021
@cnasikas cnasikas merged commit 5ce12b2 into elastic:main Nov 5, 2021
@cnasikas cnasikas deleted the remove_sn_flags branch November 5, 2021 10:44
@kibanamachine kibanamachine mentioned this pull request Nov 5, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
@cnasikas @kibanamachine
[Connectors][ServiceNow] Remove SN flags (elastic#117511)
e556127
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 8.0
❌ 7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 117511

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/add-l…
55c195e 
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
@cnasikas cnasikas mentioned this pull request Nov 5, 2021
Merged
kibanamachine added a commit that referenced this pull request Nov 5, 2021
@kibanamachine @cnasikas
[Connectors][ServiceNow] Remove SN flags (#117511) (#117634)
efeb419 
Co-authored-by: Christos Nasikas <[email protected]>
cnasikas added a commit that referenced this pull request Nov 5, 2021
@cnasikas
[Connectors][ServiceNow] Remove SN flags (#117511) (#117636)
925b6c6 
# Conflicts:
#	x-pack/plugins/security_solution/common/constants.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@semd semd semd approved these changes

Assignees

@cnasikas cnasikas

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnasikas @elasticmachine @kibanamachine @semd @YulNaumenko