Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Hide anomaly entity filter button tooltips when clicked #117493

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Nov 4, 2021

Summary

Fixes the behavior of the tooltip on the influencer filter buttons used in the Anomaly Explorer and Single Metric Viewer, so that the tooltip is hidden when the button is clicked and the view is refreshed. Previously, as shown in #116758, the tooltip would remain visible until another element was given focus.

Before:

filter_tooltip_before

After:

filter_tooltip_hide

Checklist

Fixes #116758

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 4, 2021
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1591 1592 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +230.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson peteharverson merged commit 46e91f3 into elastic:main Nov 4, 2021
@peteharverson peteharverson deleted the ml-filter-buttons-blur branch November 4, 2021 18:49
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
…#117493)

* [ML] Hide anomaly entity filter button tooltips when clicked

* [ML] Move logic into blurButtonOnClick helper function
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
…#117493)

* [ML] Hide anomaly entity filter button tooltips when clicked

* [ML] Move logic into blurButtonOnClick helper function
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
#117585)

* [ML] Hide anomaly entity filter button tooltips when clicked

* [ML] Move logic into blurButtonOnClick helper function

Co-authored-by: Pete Harverson <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
kibanamachine added a commit that referenced this pull request Nov 5, 2021
#117584)

* [ML] Hide anomaly entity filter button tooltips when clicked

* [ML] Move logic into blurButtonOnClick helper function

Co-authored-by: Pete Harverson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly explorer - influencer filter button tooltip stays after click
5 participants