Skip to content

Commit

Permalink
[ML] Functional tests - stabilize and re-enable feature importance te…
Browse files Browse the repository at this point in the history
…sts (elastic#117503)

This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.
  • Loading branch information
pheyos authored and kibanamachine committed Nov 5, 2021
1 parent 60ddfa3 commit 1dc26c5
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export default function ({ getService }: FtrProviderContext) {
training_percent: 35,
prediction_field_name: 'CentralAir_prediction',
num_top_classes: -1,
max_trees: 10,
},
},
model_memory_limit: '60mb',
Expand Down Expand Up @@ -108,6 +109,7 @@ export default function ({ getService }: FtrProviderContext) {
training_percent: 35,
prediction_field_name: 'heatingqc',
num_top_classes: -1,
max_trees: 10,
},
},
model_memory_limit: '60mb',
Expand Down Expand Up @@ -139,6 +141,7 @@ export default function ({ getService }: FtrProviderContext) {
dependent_variable: 'stab',
num_top_feature_importance_values: 5,
training_percent: 35,
max_trees: 10,
},
},
analyzed_fields: {
Expand Down
29 changes: 29 additions & 0 deletions x-pack/test/functional/services/ml/data_frame_analytics_results.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export function MachineLearningDataFrameAnalyticsResultsProvider(

async assertTotalFeatureImportanceEvaluatePanelExists() {
await testSubjects.existOrFail('mlDFExpandableSection-FeatureImportanceSummary');
await this.scrollFeatureImportanceIntoView();
await testSubjects.existOrFail('mlTotalFeatureImportanceChart', { timeout: 30 * 1000 });
},

Expand Down Expand Up @@ -213,5 +214,33 @@ export function MachineLearningDataFrameAnalyticsResultsProvider(
expect(buttonVisible).to.equal(true, 'Expected data grid cell button to be visible');
});
},

async scrollContentSectionIntoView(sectionId: string) {
await testSubjects.scrollIntoView(`mlDFExpandableSection-${sectionId}`);
},

async scrollAnalysisIntoView() {
await this.scrollContentSectionIntoView('analysis');
},

async scrollRegressionEvaluationIntoView() {
await this.scrollContentSectionIntoView('RegressionEvaluation');
},

async scrollClassificationEvaluationIntoView() {
await this.scrollContentSectionIntoView('ClassificationEvaluation');
},

async scrollFeatureImportanceIntoView() {
await this.scrollContentSectionIntoView('FeatureImportanceSummary');
},

async scrollScatterplotMatrixIntoView() {
await this.scrollContentSectionIntoView('splom');
},

async scrollResultsIntoView() {
await this.scrollContentSectionIntoView('results');
},
};
}

0 comments on commit 1dc26c5

Please sign in to comment.