[Unified Integrations] Remove and cleanup add data views #115424

joshdover · 2021-10-18T17:32:43Z

Summary

Depends on #114911 being merged first
Fixes #94181 #113434

Fix full page refreshes on Solution empty states
Add redirects from old add data views to integrations app
Fix breadcrumbs in add data views
Remove add data list view
Disable welcome interstitial if no integrations access

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

… permissions

…te_links_and_permissions

thomasneirynck · 2021-10-19T04:22:30Z

@elasticmachine merge upstream

kibanamachine · 2021-10-19T04:22:31Z

merge conflict between base and head

…er/kibana into joshdover-integrations/dover-fixes

…egrations/dover-fixes

thomasneirynck · 2021-10-19T04:39:38Z

@joshdover I merged master into your branch 4c26457

Required a few manual conflict fixes. I did a few spotchecks, and seems ok, but please verify as well. thx!

elasticmachine · 2021-10-19T04:50:51Z

Pinging @elastic/fleet (Team:Fleet)

src/plugins/home/public/application/components/home.tsx

src/plugins/home/public/application/components/home.test.tsx

src/plugins/home/public/application/components/home_app.js

…r-fixes

Dosant

app-services code lgtm, didn't test

kibanamachine · 2021-10-19T14:43:47Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`home`	80.9KB	81.2KB	+240.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	80.9KB	80.9KB	+33.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

) Co-authored-by: cchaos <[email protected]> Co-authored-by: Dave Snider <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Thomas Neirynck <[email protected]>

kibanamachine · 2021-10-19T14:46:43Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

…115581) Co-authored-by: cchaos <[email protected]> Co-authored-by: Dave Snider <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Thomas Neirynck <[email protected]> Co-authored-by: Josh Dover <[email protected]> Co-authored-by: cchaos <[email protected]> Co-authored-by: Dave Snider <[email protected]> Co-authored-by: Thomas Neirynck <[email protected]>

dikshachauhan-qasource · 2021-10-25T11:40:59Z

Hi @joshdover

Under validation of Ticket : #113434, we have following observations:

Updated breadcrumbs displayed in the form of: Integrations > .
on Clicking the Integrations breadcrumb user redirected back to the Integrations app /app/integrations/browse
No Add data breadcrumb is visible user is directly navigarted to Integration tab even for sample data.

Build details:
7.16 BC1
BUILD 45504
COMMIT 9231d80
Link: https://staging.elastic.co/7.16.0-255b8273/downloads/beats/elastic-agent/elastic-agent-7.16.0-windows-x86_64.zip

Recording:

Recording.16.mp4

Query:
While navigating from try sample data link under Home page, we observed Home Breadcrumb for few seconds while Integration page is being uploaded.

Is this expected. Could you please confirm on this.

Thanks
QAS

cchaos and others added 30 commits October 13, 2021 15:36

Completely remove Beats card

177f3d0

Added category for easily adding integration links and checking for…

040a728

… permissions

Example of simplified use in Security

3ea65dc

Merge remote-tracking branch 'upstream/master' into integrations/upda…

03e8113

…te_links_and_permissions

fix links and titles to cards

171f889

empty state card updates. change add data to add integrations

ac836c4

analytics copy

28c1fa3

Merge remote-tracking branch 'upstream/master' into integrations/upda…

6384a1a

…te_links_and_permissions

feedback

7abd79f

more link and test cleanup

9336c01

clean up the tutorial views and hide notices and tabs

20066a8

Merge remote-tracking branch 'upstream/master' into integrations/upda…

3133485

…te_links_and_permissions

jest

d237571

point to obs APM agents

e061a7a

i18n and other test fixes

b85ec15

remove tests no longer needed

013cf67

more consistant copy

877d4ec

Merge remote-tracking branch 'upstream/master' into integrations/upda…

cc0aecc

…te_links_and_permissions

fix jest tests mock

c58a8fa

address feedback

273552a

feedback

1a34739

Merge branch 'master' into integrations/update_links_and_permissions

bd68272

remove data tutorial tests since tabs no longer exist

961b599

remove directory notice components

8b5b576

i18n fixes

73d0e09

a11 hack

c219990

Merge remote-tracking branch 'upstream/master' into integrations/upda…

a3a7125

…te_links_and_permissions

screenreader rather than hack

9142b85

Merge remote-tracking branch 'upstream/master' into integrations/upda…

c99e038

…te_links_and_permissions

fix fleet/integrations link

54d9fb6

Fix full page refreshes on Solution empty states

5abd0c8

joshdover added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 Feature:Unified Integrations Unified Integrations view feature labels Oct 18, 2021

thomasneirynck added 2 commits October 19, 2021 00:22

Merge branch 'integrations/dover-fixes' of https://github.com/joshdov…

46c7fb0

…er/kibana into joshdover-integrations/dover-fixes

Merge branch 'master' of github.com:elastic/kibana into joshdover-int…

4c26457

…egrations/dover-fixes

remove unused translations

fabaac2

thomasneirynck marked this pull request as ready for review October 19, 2021 04:50

thomasneirynck requested review from a team as code owners October 19, 2021 04:50

pgayvallet approved these changes Oct 19, 2021

View reviewed changes

src/plugins/home/public/application/components/home.tsx Outdated Show resolved Hide resolved

src/plugins/home/public/application/components/home.test.tsx Outdated Show resolved Hide resolved

src/plugins/home/public/application/components/home_app.js Show resolved Hide resolved

joshdover added 2 commits October 19, 2021 14:27

Fix tests and address feedback

4c69e46

Merge remote-tracking branch 'upstream/master' into integrations/dove…

c129787

…r-fixes

joshdover enabled auto-merge (squash) October 19, 2021 12:28

joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 19, 2021

Dosant approved these changes Oct 19, 2021

View reviewed changes

joshdover merged commit 96c89e0 into elastic:master Oct 19, 2021

kibanamachine mentioned this pull request Oct 19, 2021

[7.x] [Unified Integrations] Remove and cleanup add data views (#115424) #115581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified Integrations] Remove and cleanup add data views #115424

[Unified Integrations] Remove and cleanup add data views #115424

joshdover commented Oct 18, 2021

thomasneirynck commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

thomasneirynck commented Oct 19, 2021

elasticmachine commented Oct 19, 2021

Dosant left a comment •

edited

Loading

kibanamachine commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

dikshachauhan-qasource commented Oct 25, 2021

[Unified Integrations] Remove and cleanup add data views #115424

[Unified Integrations] Remove and cleanup add data views #115424

Conversation

joshdover commented Oct 18, 2021

Summary

Checklist

Risk Matrix

For maintainers

thomasneirynck commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

thomasneirynck commented Oct 19, 2021

elasticmachine commented Oct 19, 2021

Dosant left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Oct 19, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Oct 19, 2021

💚 Backport successful

dikshachauhan-qasource commented Oct 25, 2021

Dosant left a comment •

edited

Loading