[App Search] Wired up organic results on Curation Suggestions view #114717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
force-pushed
the
organic-results-suggestions
branch
from
430e204 to
df70b3a
Compare
JasonStoltz
force-pushed
the
organic-results-suggestions
branch
from
df70b3a to
0494263
Compare
|
@elasticmachine merge upstream |
JasonStoltz
changed the title
byronhulcher
added
auto-backport
byronhulcher
approved these changes
Oct 18, 2021
| operation: 'create' | 'update' | 'delete'; | ||
| override_curation_id?: string; | ||
| } | ||
|
|
||
| // A curation suggestion with linked ids hydrated with actual values | ||
| export interface HydratedCurationSuggestion |
There was a problem hiding this comment.
Nice use of typescript here!
| values.engine.schema | ||
| ); | ||
| }); | ||
|
|
||
| it('shows an empty prompt when there are no organic results', () => { |
| @@ -116,9 +116,9 @@ describe('search relevance insights routes', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('POST /internal/app_search/engines/{name}/search_relevance_suggestions/{query}', () => { | |||
| describe('GET /internal/app_search/engines/{engineName}/search_relevance_suggestions/{query}', () => { | |||
There was a problem hiding this comment.
This makes me think whether we should differentiating between internal and public API paths more plainly. Otherwise I have to dig into the routes file to know whether its hitting /as/ or /api/as/ and I think we do have duplicate paths.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 19, 2021
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
|
Backported in #115650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The organic results section of the suggestion detail view was previously hard-coded to show mock data.
This PR uses a new dashboard endpoint API endpoint to render that section.
This new API endpoint additionally replaces a series of multiple API calls that view previously needed to make in order to hydrate all necessary data.
In addition to showing organic search results, I also added an EuiEmptyPrompt when there are no organic results to show.
Checklist
Delete any items that are not applicable to this PR.
For maintainers