[Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule #115101

dhurley14 · 2021-10-14T21:03:41Z

Summary

Copy actions related data from legacy actions sidecar into rule.actions param on the rule whenever a user performs an update / patch on the rule data.

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…PUT or PATCH

…save

dhurley14 · 2021-10-15T22:01:24Z

@elasticmachine merge upstream

…save

…ng actions

elasticmachine · 2021-10-18T16:03:36Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts

FrankHassanabad

I left comments but in order to speed up development with the upcoming feature freeze I am going to give this a LGTM so we can check this in as is to start with and then iterate over the bug pointed and others can write tests agains this if needed.

…save

FrankHassanabad · 2021-10-18T22:09:49Z

x-pack/plugins/security_solution/server/lib/detection_engine/rules/utils.ts

+   * and putting that into the actions array of the rule, then set the rules onThrottle property, notifyWhen and throttle from null -> actualy value (1hr etc..)
+   * Then use the rules client to delete the siem.notification
+   * Then with the legacy Rule Actions saved object type, just delete it.
+   */


I'd add these comments to the function as JSDoc now.

FrankHassanabad · 2021-10-18T22:25:41Z

x-pack/plugins/security_solution/server/lib/detection_engine/rules/update_rules.ts

  };

+  const [validated, errors] = validate(newInternalRule, internalRuleUpdate);
+  if (errors != null || validated === null) {
+    throw new UpdateError(`Applying update would create invalid rule: ${errors}`, 400);


Why do we have this extra error throw here now? I wouldn't want to add another layer of validation. We are already validating the input arguments and then the response on the way out. We typically just validate on the API boundaries to ensure that the 3rd party services and user input work as we expect.

Within the boundaries we usually trust we are writing code well enough and straight forward enough. If this begins causing errors at this point I would want to fix the user input at the REST API boundary or the response boundary rather than fix issues here or worry about this part.

Otherwise future maintainers might have to maintain multiple spots of validation or change error codes in multiple spots, etc...

I actually saw this was missing here. This same piece is in the patch rules function

kibana/x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts

Lines 204 to 207 in 512d594

const [validated, errors] = validate(newRule, internalRuleUpdate);

if (errors != null || validated === null) {

throw new PatchError(`Applying patch would create invalid rule: ${errors}`, 400);

}

And I figured it would be good to add it here to keep it consistent.

dhurley14 · 2021-10-19T02:57:05Z

@elasticmachine merge upstream

dhurley14 · 2021-10-19T11:37:46Z

@elasticmachine merge upstream

kibanamachine · 2021-10-19T11:37:48Z

merge conflict between base and head

kibanamachine · 2021-10-19T14:07:42Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: c7cab46
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup2

Test Failures

Kibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/106547

[00:00:00]     │
[00:00:00]       └-: saved objects tagging - functional tests
[00:00:00]         └-> "before all" hook in "saved objects tagging - functional tests"
[00:00:00]         └-> "before all" hook in "saved objects tagging - functional tests"
[00:00:00]           │ debg creating role kibana_rbac_default_space_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_management_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_management_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_management_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_management_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_tagging_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_tagging_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_tagging_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_tagging_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_dashboard_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_dashboard_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_dashboard_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_dashboard_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_visualize_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_visualize_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_visualize_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_visualize_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_advanced_settings_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_advanced_settings_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_maps_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_maps_read_user]
[00:00:00]           │ debg creating user not_a_kibana_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [not_a_kibana_user]
[00:00:00]           │ debg created user not_a_kibana_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_read_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_read_user]
[00:00:00]           │ debg created user a_kibana_rbac_default_space_read_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_management_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_management_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_management_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_tagging_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_tagging_read_so_management_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_read_so_management_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_read_so_management_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_tagging_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_dashboard_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_dashboard_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_dashboard_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_visualize_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_visualize_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_visualize_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_dashboard_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_dashboard_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_dashboard_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_visualize_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_visualize_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_visualize_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_advanced_settings_read_user
[00:00:02]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_advanced_settings_read_user]
[00:00:02]           │ debg created user a_kibana_rbac_default_space_advanced_settings_read_user
[00:00:02]           │ debg creating user a_kibana_rbac_default_space_maps_read_user
[00:00:02]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_maps_read_user]
[00:00:02]           │ debg created user a_kibana_rbac_default_space_maps_read_user
[00:05:44]         └-: dashboard integration
[00:05:44]           └-> "before all" hook in "dashboard integration"
[00:05:44]           └-> "before all" hook in "dashboard integration"
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Loading "mappings.json"
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Loading "data.json"
[00:05:44]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_task_manager_8.0.0_001/J63c301LRxWXvp-P3v0Rlg] deleting index
[00:05:44]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_001/4pkg-qCZShi2sVwoGwkipg] deleting index
[00:05:44]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_1/6qDHBJ2tRWqb3DJwBURtiA] deleting index
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_8.0.0_001"
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_1"
[00:05:44]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:05:44]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Created index ".kibana_1"
[00:05:44]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:05:44]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Indexed 12 docs into ".kibana"
[00:05:44]             │ debg Migrating saved objects
[00:05:44]             │ proc [kibana] [2021-10-19T13:04:08.479+00:00][INFO ][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 3ms.
[00:05:44]             │ proc [kibana] [2021-10-19T13:04:08.482+00:00][INFO ][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 8ms.
[00:05:44]             │ proc [kibana] [2021-10-19T13:04:08.484+00:00][INFO ][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> CHECK_UNKNOWN_DOCUMENTS. took: 2ms.
[00:05:44]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:05:44]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:05:44]             │ proc [kibana] [2021-10-19T13:04:08.491+00:00][INFO ][savedobjects-service] [.kibana] CHECK_UNKNOWN_DOCUMENTS -> SET_SOURCE_WRITE_BLOCK. took: 7ms.
[00:05:45]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_1/trrfBJ14SAiD_izc-r809g]]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_task_manager_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_task_manager_8.0.0_001][0]]"
[00:05:45]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_1]
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.568+00:00][INFO ][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 89ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.588+00:00][INFO ][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CALCULATE_EXCLUDE_FILTERS. took: 97ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.592+00:00][INFO ][savedobjects-service] [.kibana] CALCULATE_EXCLUDE_FILTERS -> CREATE_REINDEX_TEMP. took: 4ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.611+00:00][INFO ][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 43ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.612+00:00][INFO ][savedobjects-service] [.kibana_task_manager] Migration completed after 136ms
[00:05:45]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_reindex_temp][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_reindex_temp][0]]"
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.677+00:00][INFO ][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 85ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.681+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 4ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.688+00:00][INFO ][savedobjects-service] [.kibana] Starting to process 12 documents.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.689+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 7ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.697+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 9ms.
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] update_mapping [_doc]
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.927+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 230ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.933+00:00][INFO ][savedobjects-service] [.kibana] Processed 12 documents out of 12.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.934+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 6ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.937+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 4ms.
[00:05:45]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ]]
[00:05:45]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:08.993+00:00][INFO ][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 56ms.
[00:05:45]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:05:45]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/jnyLcnwhRcGhh077SgP8sA] create_mapping
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.121+00:00][INFO ][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 128ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.124+00:00][INFO ][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 3ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.127+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 3ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.133+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 6ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.135+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 2ms.
[00:05:45]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/jnyLcnwhRcGhh077SgP8sA] update_mapping [_doc]
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.215+00:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 80ms.
[00:05:45]             │ info [o.e.t.LoggingTaskListener] [node-01] 7841 finished with response BulkByScrollResponse[took=24.9ms,timed_out=false,sliceId=null,updated=12,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.321+00:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:05:45]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_reindex_temp/zwV-k_Y5RJSCkQZHKfXkKQ] deleting index
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.367+00:00][INFO ][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 46ms.
[00:05:45]             │ proc [kibana] [2021-10-19T13:04:09.368+00:00][INFO ][savedobjects-service] [.kibana] Migration completed after 894ms
[00:05:45]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Migrated Kibana index after loading Kibana data
[00:05:45]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Ensured that default space exists in .kibana
[00:05:45]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Loading "mappings.json"
[00:05:45]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Loading "data.json.gz"
[00:05:45]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:05:45]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.22"
[00:05:45]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:45]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:05:45]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:05:45]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.20"
[00:05:45]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:46]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:05:46]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:05:46]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.21"
[00:05:46]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:55]             │ info progress: 11733
[00:05:57]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:05:57]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:05:57]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:07:36]           └-: editing
[00:07:36]             └-> "before all" hook for "allows to select tags for an existing dashboard"
[00:07:36]             └-> allows to select tags for an existing dashboard
[00:07:36]               └-> "before each" hook: global before each for "allows to select tags for an existing dashboard"
[00:07:36]               └-> "before each" hook for "allows to select tags for an existing dashboard"
[00:07:36]                 │ debg navigating to dashboard url: http://localhost:61221/app/dashboards#/list
[00:07:36]                 │ debg navigate to: http://localhost:61221/app/dashboards#/list
[00:07:36]                 │ debg browser[INFO] http://localhost:61221/app/dashboards?_t=1634648759885#/list 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:36]                 │
[00:07:36]                 │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:36]                 │ debg ... sleep(700) start
[00:07:37]                 │ debg ... sleep(700) end
[00:07:37]                 │ debg returned from get, calling refresh
[00:07:38]                 │ debg browser[INFO] http://localhost:61221/app/dashboards?_t=1634648759885#/list 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:38]                 │
[00:07:38]                 │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:38]                 │ debg currentUrl = http://localhost:61221/app/dashboards#/list
[00:07:38]                 │          appUrl = http://localhost:61221/app/dashboards#/list
[00:07:38]                 │ debg TestSubjects.find(kibanaChrome)
[00:07:38]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:07:38]                 │ debg ... sleep(501) start
[00:07:39]                 │ debg ... sleep(501) end
[00:07:39]                 │ debg in navigateTo url = http://localhost:61221/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:07:39]                 │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[00:07:39]                 │ debg ... sleep(501) start
[00:07:40]                 │ debg ... sleep(501) end
[00:07:40]                 │ debg in navigateTo url = http://localhost:61221/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:07:40]                 │ debg gotoDashboardLandingPage
[00:07:40]                 │ debg onDashboardLandingPage
[00:07:40]                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:07:40]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:07:40]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="itemsInMemTable"]:not(.euiBasicTable-loading)') with timeout=2500
[00:07:40]               │ debg TestSubjects.click(dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1))
[00:07:40]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1)"]') with timeout=10000
[00:07:40]               │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1)"]') with timeout=10000
[00:07:40]               │ debg Switching to edit mode
[00:07:40]               │ debg TestSubjects.exists(dashboardEditMode)
[00:07:40]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardEditMode"]') with timeout=2500
[00:07:40]               │ debg browser[INFO] http://localhost:61221/app/dashboards#/view/61c58ad0-3dd3-11e8-b2b9-5d5dc1715159?_g=(filters:!()) 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:40]               │
[00:07:40]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:43]               │ debg --- retry.tryForTime error: [data-test-subj="dashboardEditMode"] is not displayed
[00:07:43]               │ debg browser[WARNING] http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js 20:68465 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
[00:07:43]               │      Arguments: 
[00:07:43]               │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Mon Apr 09 2018 17:56:08 GMT-0400, _f: undefined, _strict: undefined, _locale: [object Object]
[00:07:43]               │      Error
[00:07:43]               │          at Function.createFromInputFallback (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:68894)
[00:07:43]               │          at http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89070
[00:07:43]               │          at http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89121
[00:07:43]               │          at Ot (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89433)
[00:07:43]               │          at wt (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89694)
[00:07:43]               │          at Mt (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89776)
[00:07:43]               │          at r (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:65816)
[00:07:43]               │          at Object.l [as parse] (http://localhost:61221/47304/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:340:135055)
[00:07:43]               │          at http://localhost:61221/47304/bundles/plugin/data/kibana/data.plugin.js:1:129886
[00:07:43]               │          at t._next (http://localhost:61221/47304/bundles/plugin/data/kibana/data.plugin.js:1:129960)"
[00:07:43]               │ debg Waiting up to 20000ms for in edit mode...
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:43]               │ warn browser[SEVERE] http://localhost:61221/api/index_patterns/_fields_for_wildcard?pattern=animals-*&meta_fields=_source&meta_fields=_id&meta_fields=_type&meta_fields=_index&meta_fields=_score - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:43]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.async-search] creating index, cause [auto(bulk api)], templates [], shards [1]/[0]
[00:07:43]               │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.async-search][0]]])." previous.health="YELLOW" reason="shards started [[.async-search][0]]"
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:45]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/jnyLcnwhRcGhh077SgP8sA] update_mapping [_doc]
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:49]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/jnyLcnwhRcGhh077SgP8sA] update_mapping [_doc]
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:02]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:02]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:02]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:02]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:02]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:02]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:02]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:02]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:03]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:03]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:03]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:03]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:04]               │ info Taking screenshot "/dev/shm/workspace/parallel/22/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard.png"
[00:08:04]               │ info Current URL is: http://localhost:61221/app/dashboards#/view/61c58ad0-3dd3-11e8-b2b9-5d5dc1715159?_g=(filters:!())
[00:08:04]               │ info Saving page source to: /dev/shm/workspace/parallel/22/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard.html
[00:08:04]               └- ✖ fail: saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard
[00:08:04]               │      Error: timed out waiting for in edit mode
[00:08:04]               │       at onFailure (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
[00:08:04]               │       at retryForSuccess (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:59:13)
[00:08:04]               │       at retryForTruthy (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
[00:08:04]               │       at RetryService.waitFor (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry.ts:59:5)
[00:08:04]               │       at DashboardPageObject.switchToEditMode (/dev/shm/workspace/parallel/22/kibana/test/functional/page_objects/dashboard_page.ts:257:5)
[00:08:04]               │       at Context.<anonymous> (test/saved_object_tagging/functional/tests/dashboard_integration.ts:166:9)
[00:08:04]               │       at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:08:04]               │ 
[00:08:04]               │

Stack Trace

Error: timed out waiting for in edit mode
    at onFailure (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
    at retryForSuccess (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:59:13)
    at retryForTruthy (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
    at RetryService.waitFor (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry.ts:59:5)
    at DashboardPageObject.switchToEditMode (/dev/shm/workspace/parallel/22/kibana/test/functional/page_objects/dashboard_page.ts:257:5)
    at Context.<anonymous> (test/saved_object_tagging/functional/tests/dashboard_integration.ts:166:9)
    at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

✅ unchanged

History

💔 Build #162462 failed 9feda3a
💔 Build #162317 failed 4c454c0
💔 Build #162172 failed 2f74c4e
💔 Build #162038 failed cc67c59
💚 Build #161697 succeeded 9fd0bc555a8bb97d85a72f238feea437cfa6756c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

…nteracts with the rule (elastic#115101) Migrate legacy actions whenever user interacts with the rule (elastic#115101) Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-10-19T14:10:54Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…nteracts with the rule (#115101) (#115572) Migrate legacy actions whenever user interacts with the rule (#115101) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Devin W. Hurley <[email protected]>

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

dhurley14 added 6 commits October 14, 2021 15:59

WIP - undo me

a88290b

move migration code into update rules so it is called no matter HTTP …

cea2025

…PUT or PATCH

cleanup

1ffd393

Merge remote-tracking branch 'upstream/master' into rules_migrate_on_…

d3be062

…save

remove duplicate code

d77f889

remove unused import

d536121

dhurley14 added 2 commits October 18, 2021 09:04

delete commented-out code

d3cd83b

Merge remote-tracking branch 'upstream/master' into rules_migrate_on_…

cc67c59

…save

dhurley14 force-pushed the rules_migrate_on_save branch from 9fd0bc5 to cc67c59 Compare October 18, 2021 13:07

update patchRules function with same logic as updateRules for migrati…

2f74c4e

…ng actions

dhurley14 self-assigned this Oct 18, 2021

dhurley14 changed the title ~~[Security Solution] [Platform] migrate actions on touch~~ [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule Oct 18, 2021

dhurley14 marked this pull request as ready for review October 18, 2021 16:03

dhurley14 requested a review from a team as a code owner October 18, 2021 16:03

dhurley14 added the release_note:enhancement label Oct 18, 2021

FrankHassanabad reviewed Oct 18, 2021

View reviewed changes

x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts Outdated Show resolved Hide resolved

FrankHassanabad reviewed Oct 18, 2021

View reviewed changes

x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts Outdated Show resolved Hide resolved

FrankHassanabad reviewed Oct 18, 2021

View reviewed changes

x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts Outdated Show resolved Hide resolved

FrankHassanabad approved these changes Oct 18, 2021

View reviewed changes

dhurley14 added 2 commits October 18, 2021 16:33

updates with feedback on PR

6498ff3

Merge remote-tracking branch 'upstream/master' into rules_migrate_on_…

4c454c0

…save

FrankHassanabad reviewed Oct 18, 2021

View reviewed changes

execute migration before the patch / update calls

5059c56

Merge branch 'master' into rules_migrate_on_save

9feda3a

Merge branch 'master' into rules_migrate_on_save

c7cab46

dhurley14 enabled auto-merge (squash) October 19, 2021 12:10

dhurley14 merged commit 1a91767 into elastic:master Oct 19, 2021

kibanamachine mentioned this pull request Oct 19, 2021

[7.x] [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (#115101) #115572

Merged

joepeeples mentioned this pull request Nov 6, 2021

[DOCS] 7.16.0 Release Notes elastic/security-docs#1179

Closed

dhurley14 mentioned this pull request Sep 17, 2024

[Security Solution] [Detections] Provide field-specific suppression configuration to all rule types #193110

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule #115101

[Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule #115101

dhurley14 commented Oct 14, 2021 •

edited

Loading

dhurley14 commented Oct 15, 2021

elasticmachine commented Oct 18, 2021

FrankHassanabad left a comment

FrankHassanabad Oct 18, 2021

FrankHassanabad Oct 18, 2021 •

edited

Loading

dhurley14 Oct 18, 2021 •

edited

Loading

dhurley14 commented Oct 19, 2021

dhurley14 commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

Standard Out

Stack Trace

kibanamachine commented Oct 19, 2021

	const [validated, errors] = validate(newRule, internalRuleUpdate);
	if (errors != null \|\| validated === null) {
	throw new PatchError(`Applying patch would create invalid rule: ${errors}`, 400);
	}

[Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule #115101

[Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule #115101

Conversation

dhurley14 commented Oct 14, 2021 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

dhurley14 commented Oct 15, 2021

elasticmachine commented Oct 18, 2021

FrankHassanabad left a comment

Choose a reason for hiding this comment

FrankHassanabad Oct 18, 2021

Choose a reason for hiding this comment

FrankHassanabad Oct 18, 2021 • edited Loading

Choose a reason for hiding this comment

dhurley14 Oct 18, 2021 • edited Loading

Choose a reason for hiding this comment

dhurley14 commented Oct 19, 2021

dhurley14 commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

kibanamachine commented Oct 19, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

History

kibanamachine commented Oct 19, 2021

💚 Backport successful

dhurley14 commented Oct 14, 2021 •

edited

Loading

FrankHassanabad Oct 18, 2021 •

edited

Loading

dhurley14 Oct 18, 2021 •

edited

Loading