-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v39.1.1 #114732
Upgrade EUI to v39.1.1 #114732
Conversation
- Popover ID was removed in recent EUI a11y fix, so we're using child-position selection to target the Tags filter now
@elasticmachine merge upstream |
Security Cypress |
@elasticmachine merge upstream |
cy.get(TIMELINE_DATA_PROVIDER_FIELD) | ||
.find(COMBO_BOX_INPUT) | ||
.type(`${filter.field}{downarrow}{enter}`); | ||
cy.get(TIMELINE_DATA_PROVIDER_OPERATOR).find(COMBO_BOX_INPUT).type(filter.operator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I finally got data_providers.spec.ts
to fail on the 3rd rerun locally:
The Save button click is failing because the field combobox isn't being typed in as expected. I inspected the DOM and I think this is because the Cypress command is trying to type directly into the wrapping <div>
around the parent and not necessarily directly into the interactable input portion of the combobox.
Not totally sure why it's sometimes working and sometimes not (Just E2E Testing Things ™️), but I reran with this new .find(COMBO_BOX_INPUT)
addition 10 times locally and it passed each time for me.
@MadameSheema FYI - tagging you in on this change for your approval because I saw you did some Security Cypress spec improvements/refactors very recently.
Also for the record, here's the 3 CI Cypress failures on this PR: 1, 2, 3
- Got a flake on clicking the combobox dropdown on run 17/20 locally
Pinging @elastic/eui-design (EUI) |
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM looks good
@elasticmachine merge upstream |
@elastic/kibana-app-services @elastic/kibana-presentation @elastic/kibana-reporting-services @elastic/security-solution I'm hoping to merge this by EOD in time for 7.16 FF - would appreciate your review before then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see elastic/eui#5268 included, as that will be needed for the Controls project. Presentation team changes LGTM!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are nullStandard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* Upversion to EUI 39.1.0 * Update i18n_eui_mapping tokens @see https://github.com/elastic/eui/blob/master/i18ntokens_changelog.json * Merge refractor in yarn.lock * Fix functional table filter selector - Popover ID was removed in recent EUI a11y fix, so we're using child-position selection to target the Tags filter now * Update snaphots * Upgrade to 39.1.1 for extra bugfixes * Update i18n mappings * Fix i18n snapshot * Attempt to harden flaky Security Cypress test * More combobox entry hardening - Got a flake on clicking the combobox dropdown on run 17/20 locally Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
* Upversion to EUI 39.1.0 * Update i18n_eui_mapping tokens @see https://github.com/elastic/eui/blob/master/i18ntokens_changelog.json * Merge refractor in yarn.lock * Fix functional table filter selector - Popover ID was removed in recent EUI a11y fix, so we're using child-position selection to target the Tags filter now * Update snaphots * Upgrade to 39.1.1 for extra bugfixes * Update i18n mappings * Fix i18n snapshot * Attempt to harden flaky Security Cypress test * More combobox entry hardening - Got a flake on clicking the combobox dropdown on run 17/20 locally Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Constance <[email protected]>
Summary
[email protected]
⏩[email protected]
39.1.1
Bug fixes
SuperDatePicker
from crashing due to invalid time input (#5263)EuiFilterButton
again whennumFilters
is undefined (#5268)39.1.0
ghost
andtext
EuiIcon
colors on Elastic logos (#5245)data-test-subj
toEuiErrorBoundary
(#5232)Bug fixes
EuiPopover
from being inaccessible during the opening animation (#5249)EuiBasicTable
andEuiInMemoryTable
(#5241)