Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Upgrade EUI to v39.1.1 (#114732) #115598

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* Upversion to EUI 39.1.0

* Update i18n_eui_mapping tokens

@see https://github.com/elastic/eui/blob/master/i18ntokens_changelog.json

* Merge refractor in yarn.lock

* Fix functional table filter selector

- Popover ID was removed in recent EUI a11y fix, so we're using child-position selection to target the Tags filter now

* Update snaphots

* Upgrade to 39.1.1 for extra bugfixes

* Update i18n mappings

* Fix i18n snapshot

* Attempt to harden flaky Security Cypress test

* More combobox entry hardening

- Got a flake on clicking the combobox dropdown on run 17/20 locally

Co-authored-by: Kibana Machine <[email protected]>
@thompsongl
Copy link
Contributor

@elasticmachine merge upstream

@thompsongl
Copy link
Contributor

@elasticmachine merge upstream

@cee-chen
Copy link
Contributor

Thanks a million for the help here Greg!!

@thompsongl
Copy link
Contributor

I have electricity; it's the least I can do 😄

@kibanamachine
Copy link
Contributor Author

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 132.4KB 132.4KB -1.0B
fleet 617.9KB 617.9KB -1.0B
kibanaReact 217.3KB 217.3KB -1.0B
kibanaUtils 52.1KB 52.1KB -1.0B
security 514.6KB 514.6KB -1.0B
securitySolution 4.6MB 4.6MB -1.0B
total -6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 303.3KB 303.4KB +118.0B
kbnUiSharedDeps-css 597.0KB 597.0KB +27.0B
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +819.0B
total +964.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit c6536d4 into elastic:7.x Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants