[EuiPopover] Allow content to be accessible during opening animation #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Oct 6, 2021
cee-chen
reviewed
Oct 6, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5249/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5249/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5249/ |
1Copenut
approved these changes
Oct 11, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5249/ |
cchaos
approved these changes
Oct 12, 2021
This reverts commit bf3a363.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5249/ |
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
…lastic#5249) * remove visibiliy:hidden; rely on opacity * revert me * more visibility removal * CL * Revert "revert me" This reverts commit bf3a363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #5247 by removing
visibility: hiddenfrom EuiPopover open animation and instead relying onopacity: 0.This allows the contents of EuiPopover to be accessible to the
node.innerTextmethod as well as screen readers.Main question(s) to answer: Is it important to hide the content from screen readers during the animation, or are we doing such users a disservice by delaying access to the content? If the former, how do screen readers handle
visiblecontent inside ahiddenparent (#5247 (comment))?See the EuiProgress "Progress for charts" docs section for resolution. Each label should have a
titleattr that matches the content.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest tests