Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Added platinum license check before showing Suggestions #114549

Merged
merged 3 commits into from
Oct 12, 2021
Merged

[App Search] Added platinum license check before showing Suggestions #114549

merged 3 commits into from
Oct 12, 2021

Conversation

JasonStoltz
Copy link
Member

Summary

This PR adds a platinum license check to the Curations Overview page. If there is no platinum license, it will not show Curation Suggestions.

Checklist

@JasonStoltz JasonStoltz requested a review from a team October 11, 2021 18:43
@JasonStoltz JasonStoltz added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 11, 2021
@JasonStoltz
Copy link
Member Author

@elasticmachine merge upstream

@byronhulcher
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

@JasonStoltz JasonStoltz merged commit eb5e46a into elastic:master Oct 12, 2021
@JasonStoltz JasonStoltz deleted the check-platinum-license branch October 12, 2021 11:53
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2021
@JasonStoltz @kibanamachine
Check platinum license (elastic#114549)
6010ad9
@kibanamachine kibanamachine mentioned this pull request Oct 12, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 14, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

byronhulcher pushed a commit to JasonStoltz/kibana that referenced this pull request Oct 19, 2021
@JasonStoltz @byronhulcher
Check platinum license (elastic#114549)
b16de0b
@byronhulcher byronhulcher mentioned this pull request Oct 19, 2021
Merged
byronhulcher pushed a commit that referenced this pull request Oct 19, 2021
@JasonStoltz
[7.x] Automated Curation Backports (#114545) (#114717) (#115090) (#11…
c13cbe8 
…4549) (#115650)

* Handle deletes (#114545)

* [App Search] Wired up organic results on Curation Suggestions view (#114717)

* [App Search] Added a History tab to the Automated Curation detail view (#115090)

* Check platinum license (#114549)
@byronhulcher
Copy link
Contributor

Backported in #115650

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byronhulcher byronhulcher byronhulcher approved these changes

Assignees

@byronhulcher byronhulcher

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonStoltz @byronhulcher @kibanamachine