Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Integrations] Remove and cleanup add data views #115424

Merged
merged 41 commits into from
Oct 19, 2021
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
177f3d0
Completely remove Beats card
Oct 13, 2021
040a728
Added `category` for easily adding integration links and checking for…
Oct 13, 2021
3ea65dc
Example of simplified use in Security
Oct 13, 2021
03e8113
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 14, 2021
171f889
fix links and titles to cards
snide Oct 14, 2021
ac836c4
empty state card updates. change add data to add integrations
snide Oct 14, 2021
28c1fa3
analytics copy
snide Oct 14, 2021
6384a1a
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 14, 2021
7abd79f
feedback
snide Oct 14, 2021
9336c01
more link and test cleanup
snide Oct 14, 2021
20066a8
clean up the tutorial views and hide notices and tabs
snide Oct 14, 2021
3133485
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 14, 2021
d237571
jest
snide Oct 15, 2021
e061a7a
point to obs APM agents
snide Oct 15, 2021
b85ec15
i18n and other test fixes
snide Oct 15, 2021
013cf67
remove tests no longer needed
snide Oct 15, 2021
877d4ec
more consistant copy
snide Oct 15, 2021
cc0aecc
Merge remote-tracking branch 'upstream/master' into integrations/upda…
joshdover Oct 15, 2021
c58a8fa
fix jest tests mock
snide Oct 15, 2021
273552a
address feedback
snide Oct 15, 2021
1a34739
feedback
snide Oct 15, 2021
bd68272
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine Oct 18, 2021
961b599
remove data tutorial tests since tabs no longer exist
snide Oct 18, 2021
8b5b576
remove directory notice components
snide Oct 18, 2021
73d0e09
i18n fixes
snide Oct 18, 2021
c219990
a11 hack
snide Oct 18, 2021
a3a7125
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 18, 2021
9142b85
screenreader rather than hack
snide Oct 18, 2021
c99e038
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 18, 2021
54d9fb6
fix fleet/integrations link
snide Oct 18, 2021
9b052f0
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide Oct 18, 2021
50cd954
Disable welcome interstitial if no integrations access
joshdover Oct 18, 2021
6b9e641
Remove add data list view
joshdover Oct 18, 2021
605a703
Fix breadcrumbs in add data views
joshdover Oct 18, 2021
1667d1c
Add redirects from old add data views to integrations app
joshdover Oct 18, 2021
5abd0c8
Fix full page refreshes on Solution empty states
joshdover Oct 18, 2021
46c7fb0
Merge branch 'integrations/dover-fixes' of https://github.com/joshdov…
thomasneirynck Oct 19, 2021
4c26457
Merge branch 'master' of github.com:elastic/kibana into joshdover-int…
thomasneirynck Oct 19, 2021
fabaac2
remove unused translations
thomasneirynck Oct 19, 2021
4c69e46
Fix tests and address feedback
joshdover Oct 19, 2021
c129787
Merge remote-tracking branch 'upstream/master' into integrations/dove…
joshdover Oct 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a11 hack
  • Loading branch information
snide committed Oct 18, 2021
commit c219990e4a4a4e18149f61dce3d10895c7adcf14

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -80,7 +80,12 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
paddingSize="l"
image={image}
href={href ?? addBasePath(`/app/integrations/browse${hasCategory}`)}
title=""
// Bad hack to fix the need for an a11y title even though the button exists
title={
<span style={{ display: 'block', opacity: 0, height: 0, overflow: 'hidden' }}>
{defaultCTAtitle}
</span>
}
description={i18n.translate('kibana-react.noDataPage.elasticAgentCard.description', {
defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`,
})}
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ export function getNoDataConfig({
defaultMessage: 'Observability',
}),
actions: {
beats: {
elasticAgent: {
title: i18n.translate('xpack.observability.noDataConfig.beatsCard.title', {
defaultMessage: 'Add integrations',
}),