runtime wasm perf triggers 8 #92976
Closed
runtime wasm perf triggers 8 #92976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Miha Zupan <[email protected]>
…et#91046) * Use WasmSdk in browser template * Remove default html-path * Use wwwroot when looking for main.js in template for replacement * Temporarily remove WasmRuntimeAssetsLocation from WBT because WasmSDK doesn't support it yet * Integrate console log forward into DevServer * Replace UseRouter * Use next middleware only if it's not console * CancellationTokenSource on CancelKeyPress * Address feedback from initial DevServer integration * Update src/mono/wasm/host/BrowserHost.cs Co-authored-by: Ankit Jain <[email protected]> * Remove debugging code * Fix WBT * Fix starting outside of project directory * Support WasmRuntimeAssetsLocation in Wasm SDK * Revert "Support WasmRuntimeAssetsLocation in Wasm SDK" * Active issue for WasmRuntimeAssetsLocation * Feedback --------- Co-authored-by: Marek Fišera <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
…829.1 (dotnet#91329) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23428.2 -> To Version 8.0.0-beta.23429.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23426.1 (parent: Microsoft.DotNet.Arcade.Sdk Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet-optimization build 20230829.4 (dotnet#91330) optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23427.2 -> To Version 1.0.0-prerelease.23429.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tanner Gooding <[email protected]>
… on separate line (dotnet#91218) * Emit interceptor info correctly when invocation expr is on separate line * Add more tests and add helper to udpate baselines * Add comments to binding gen tests for invocations on new lines (dotnet#91237) * Add comments to binding gen tests for invocations on new lines * Address feedback & test static method call syntax * Reorganize and comment the newline/whitespace scenarios * Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions --------- Co-authored-by: Jeff Handley <[email protected]> * Update baselines --------- Co-authored-by: Layomi Akinrinade <[email protected]> Co-authored-by: Jeff Handley <[email protected]>
…dotnet#91346) * Fix crash when calling AssemblyLoadContext.Unload twice The AssemblyLoadContext.InitiateUnload method was not handling multiple calls correctly. Instead of making the extra calls dummy, it was calling the native runtime helper again. This change fixes it by simply ensuring that the runtime helper is called just once. * Add regression test --------- Co-authored-by: Jan Vorlicek <[email protected]>
… Build ID 2256251 (dotnet#91347) * Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251 * Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251
… Build ID 2256435 (dotnet#91360)
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.5 * Update dependencies from https://github.com/dotnet/roslyn build 20230828.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23429.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.9 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.10 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.12 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.12 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.13 * Update dependencies from https://github.com/dotnet/roslyn build 20230829.14 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.14 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23430.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.5 * Update dependencies from https://github.com/dotnet/roslyn build 20230830.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.6 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet. Fixes dotnet#77377 Co-authored-by: Jordan Borean <[email protected]>
…otnet-optimization build 20230830.6 (dotnet#91390) optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23429.4 -> To Version 1.0.0-prerelease.23430.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…and ValidateValue (dotnet#91293) * Fix nullable annotation for Validator.TryValidateValue and ValidateValue * Revert Options source generator nullable annotation changes for Validator.TryValidateValue (dotnet#91305) * Fix nullable annotation for Validator.ValidateValue ref source (dotnet#91351) --------- Co-authored-by: Jeff Handley <[email protected]>
…le S.R.E (dotnet#91352) * [DependencyInjection] introduce feature switch to disable S.R.E When recording a new AOT profile for .NET MAUI apps running on Android, we noticed that System.Reflection.Emit work was being done on a background thread. The call seen in `dotnet-trace` output: 11.32ms microsoft.extensions.dependencyinjection!Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder.GenerateMethodBody(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite,System.Reflection.Emit.ILGenerator) .NET Android apps are unique in that there is a JIT, `RuntimeFeature.IsDynamicCodeCompiled` is true, System.Reflection.Emit is possible -- S.R.E is however, not great for startup performance. Starting threads on Android during startup can also be slow, as Android will commonly put all but a single core to sleep for battery saving purposes. We try to avoid starting threads on startup for "hello world" applications on Android. To solve this for now, introduce a new feature flag: Microsoft.Extensions.DependencyInjection.DisableDynamicEngine Which, we will provide a value in either the Android or .NET MAUI optional workload via an MSBuild property. To test, I put this in my app's `.csproj` file: <RuntimeHostConfigurationOption Include="Microsoft.Extensions.DependencyInjection.DisableDynamicEngine" Condition="'$(DisableDynamicEngine)' != ''" Value="$(DisableDynamicEngine)" Trim="true" /> Customers *could* opt to change this flag, but we don't think it will particularly useful. An example of services realized by .NET MAUI at startup, via some logging added: 08-25 13:21:55.647 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeService] 08-25 13:21:55.664 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeScopedService] 08-25 13:21:55.665 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Dispatching.IDispatcher 08-25 13:21:55.668 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.LifecycleEvents.LifecycleEventRegistration] 08-25 13:21:56.057 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.HandlerMauiAppBuilderExtensions+HandlerRegistration] 08-25 13:21:56.115 16530 16530 I DOTNET : RealizeService called: Microsoft.Extensions.DependencyInjection.IServiceScopeFactory 08-25 13:21:56.670 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager 08-25 13:21:56.712 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.ImageSourcesMauiAppBuilderExtensions+ImageSourceRegistration] 08-25 13:21:57.700 16530 16530 I DOTNET : RealizeService using S.R.E: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager `HideSoftInputOnTappedChangedManager` would be realized once per page, which would not be a huge payoff to use S.R.E for. So the only way the S.R.E codepath could be useful on Android would be if the customer is registering lots of services themselves. They might be better off just using `new()` in that case? An example of the startup time Android reports with the new flag on/off: DisableDynamicEngine=false 08-25 14:31:37.462 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +733ms 08-25 14:31:39.394 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +737ms 08-25 14:31:41.326 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +730ms DisableDynamicEngine=true 08-25 14:32:20.233 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +724ms 08-25 14:32:22.137 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +727ms 08-25 14:32:24.042 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +716ms This was a `dotnet new maui` project, using dotnet/maui/main on a Pixel 5 device. * Update docs/workflow/trimming/feature-switches.md Co-authored-by: Eric Erhardt <[email protected]> --------- Co-authored-by: Jonathan Peppers <[email protected]> Co-authored-by: Jonathan Peppers <[email protected]> Co-authored-by: Eric Erhardt <[email protected]>
…invoke is enabled (dotnet#91417) * Fix offset calculation for nested struct * Add a test for nested struct with pinvoke * Move and update test with real c++ implementation * Exclude newly added test from wasm * Disable interop tests on android and apple devices --------- Co-authored-by: Fan Yang <[email protected]>
* Options Source Gen Fixes * Remove unnecessary interpolated string usage * Address the feedback * Remove repeated word in the comment --------- Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
…te (dotnet#91401) * Remove experimental wasm arguments from template and add them to features.md * Fix WBT * Use lowercase host in runtimeconfig.template.json * Override runtimeconfig only for wasmconsole --------- Co-authored-by: Marek Fišera <[email protected]> Co-authored-by: Marek Safar <[email protected]>
The precode code was incorrectly using the HOST_ARM64, HOST_ARM, etc. defines instead of the TARGET_ ones. This means the cross-DAC was using the wrong architectures *Precode::Type codes. Co-authored-by: Mike McLaughlin <[email protected]>
) We were not generating information about static virtuals on interface types. Information about default interface methods normally goes to the class, but if the T we're dispatching on is an interface, this information wasn't generated. The fix is to put this information into dispatch maps and sealed vtables, same way we do for classes. The test shows what the problem is - if we change `IBar` to be a class, things would work even before this PR. Co-authored-by: Michal Strehovský <[email protected]>
When we started generating custom modifiers into metadata format to support new function pointer APIs in dotnet#85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at dotnet#91381. No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway. Co-authored-by: Michal Strehovský <[email protected]>
…otnet-optimization build 20230831.4 (dotnet#91462) optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23430.6 -> To Version 1.0.0-prerelease.23431.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…tnet#91423) * Update dependencies from https://github.com/dotnet/emsdk build 20230831.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-rc.1.23415.5 -> To Version 8.0.0-rc.2.23431.1 Dependency coherency updates runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23423.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport * Update dependencies from https://github.com/dotnet/arcade build 20230831.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23429.1 -> To Version 8.0.0-beta.23431.2 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230831.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230831.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230831.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230831.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230901.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23451.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
… Build ID 2258306 (dotnet#91485)
* Use LoadLibraryExW on Windows. * Use correct flag. --------- Co-authored-by: Aaron R Robinson <[email protected]>
cpufeatures.h/.c uses TARGET_ ifdefs, but it should use HOST_ ifdefs
…net/icu dotnet/source-build-reference-packages dotnet/emsdk (dotnet#91500) * Update dependencies from https://github.com/dotnet/arcade build 20230901.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23431.2 -> To Version 8.0.0-beta.23451.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230901.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23451.1 * Update dependencies from https://github.com/dotnet/cecil build 2023090.2 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23428.2 -> To Version 0.11.4-alpha.23454.2 * Update dependencies from https://github.com/dotnet/icu build 2023090.2 Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-rc.2.23421.2 -> To Version 8.0.0-rc.2.23454.2 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230905.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23455.1 * Bump Microsoft.Private.Intellisense package version (cherry picked from commit 94d7ad5) * Update dependencies from https://github.com/dotnet/emsdk build 20230905.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.2 * Update dependencies from https://github.com/dotnet/emsdk build 20230905.4 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.4 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Carlos Sánchez López <[email protected]>
…#91602) Co-authored-by: Layomi Akinrinade <[email protected]>
… generator is enabled (dotnet#91559) * Enable interceptors implicitly in binder gen nupkg when generator is enabled * Simplify impl & remove unneeded target --------- Co-authored-by: Layomi Akinrinade <[email protected]>
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.5 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.8 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.9 * Update dependencies from https://github.com/dotnet/roslyn build 20230922.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.10 * Update dependencies from https://github.com/dotnet/roslyn build 20230923.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230923.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230923.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230923.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230924.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230924.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230924.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.2 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.5 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.6 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.8 * Update dependencies from https://github.com/dotnet/roslyn build 20230925.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.10 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.6 * Small refactor to BuildElement to address NRT changes * Update dependencies from https://github.com/dotnet/roslyn build 20230926.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.13 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.14 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.14 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.15 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.15 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.21 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.21 * Update dependencies from https://github.com/dotnet/roslyn build 20230926.22 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.22 * Update dependencies from https://github.com/dotnet/roslyn build 20230927.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230927.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.4 * Update dependencies from https://github.com/dotnet/roslyn build 20230928.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.3 * Update dependencies from https://github.com/dotnet/roslyn build 20230928.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.4 * Update dependencies from https://github.com/dotnet/roslyn build 20231001.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23501.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Levi Broderick <[email protected]> Co-authored-by: Fred Silberberg <[email protected]>
* Make config binding gen incremental * Iterate on implementation * Add incremental tests & driver * Make incremental tests pass and revert functional regression * Address failing tests * Make tests pass * Suppress diagnostic * Address feedback on diag info creation * Refactor member access expr parsing to indicate assumptions * Address feedback & do misc clean up * Adjust model to minimize baseline diff / misc clean up Co-authored-by: Carlos Sánchez López <[email protected]>
* [wasm] Endian fix for Webcil 'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines. We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly. * Fix infinite recursion * rename var --------- Co-authored-by: Sanjam Panda <[email protected]> Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
…nals build 20231002.1 (dotnet#92935) Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23475.1 -> To Version 8.0.0-alpha.1.23502.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…utils (dotnet#92932) * Update dependencies from https://github.com/dotnet/cecil build 20231002.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1 * Update dependencies from https://github.com/dotnet/hotreload-utils build 20231002.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…et#92906) * [wasm] Ignore empty `$ASPNETCORE_URLS` * [wasm] DevServer: honor urls specified in the options * [wasm] CI: Don't trigger non-wbt jobs on wasm-app-host changes * CI: don't trigger wasm runtime tests on wasm-app-host changes * [wasm] wasmbrowser - change the default webserver port to 0, to randomly select a port
Co-authored-by: David Mason <[email protected]>
radical
requested review from
jeffhandley,
marek-safar,
sbomer,
lewing,
pavelsavara,
thaystg,
kg,
vargaz,
lambdageek,
BrzVlad,
kotlarmilos,
SamMonoRT and
MichalStrehovsky
as code owners
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembler::ReflectionNotation()([release/8.0-rc1] Fix problems withAssembler::ReflectionNotation()#90655)-msimd128([release/8.0-rc1] [wasm] Do not build mono libs with-msimd128#90750)--make-repro-pathILC option #90989)PEImageshould not permitm_pathfield mutation ([release/8.0]PEImageshould not permitm_pathfield mutation #91085)ComWrappersRCW cache #91149)System.IO.Hashingtests on ios and disable them on tvos #91195)EmccMaximumHeapSizeto define maximum memory ([release/8.0] [browser] AddEmccMaximumHeapSizeto define maximum memory #91277)Item4is missing in someValueTuples'IStructuralEquatable.Equals([release/8.0] FixItem4is missing in someValueTuples'IStructuralEquatable.Equals#91470)Marshal.QueryInterface()argument modifier #91984)InlineArrayin the trimmer ([release/8.0] Implement support forInlineArrayin the trimmer #92107)IDispatchshould acceptHRESULTas valuetype ([release/8.0-rc2]IDispatchshould acceptHRESULTas valuetype #92494)dotnet/installer([release/8.0] Update dependencies fromdotnet/installer#92795)DevServer([release/8.0][wasm] Use intended ports when runningDevServer#92906)