[release/8.0] fix ReceiveFrom with dual mode socket #92103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #92086 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
rzikm
approved these changes
Sep 15, 2023
|
I approve - it is a regression and the fix is not that complicated. Given the privacy concerns, I would take it. @artl93 ready for your approval |
artl93
added
Servicing-approved
|
The tvos-arm64 legs might be stuck. |
it is finished now, all check are green. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92086 to release/8.0
Fixes #92006
/cc @karelz @wfurt
Customer Impact
Regression against .NET 7.0
When UDP user uses IPv4 address (on machine with IPv6 enabled as well - which is typical scenario), they may get wrong peer address from
Socket.ReceiveFrom(the main API for receiving data for UDP). As a result, they may start sending UDP packets to the wrong endpoint - potentially leading to privacy problems.There is a workaround to pass the address with correct
AddressFamily, but that requires the developer to anticipate the problem.The regression was introduced by PR #89841 (UDP perf improvements).
Testing
Targeted tests are added in the PR
Verified on E2E original repro from #92006 (using managed QUIC implementation side project)
Risk
Medium. UDP is used much less than TCP (also partially due to its suboptimal performance prior to .NET 8.0).