Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json from 13.0.1 to 13.0.3 #92277

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

mthalman
Copy link
Member

.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

This was missed as part of the initial set of work to update all repos to 13.0.3.

Related to dotnet/source-build-externals#195 and dotnet/source-build#3629

@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

This was missed as part of the initial set of work to update all repos to 13.0.3.

Related to dotnet/source-build-externals#195 and dotnet/source-build#3629

Author: mthalman
Assignees: mthalman
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 19, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 19, 2023
@mthalman
Copy link
Member Author

@carlossanlop - Yes, RC2 would be good

@mthalman
Copy link
Member Author

Looks like there's a build issue though

@mthalman
Copy link
Member Author

I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.

@ViktorHofer
Copy link
Member

@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).

@mthalman
Copy link
Member Author

@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).

Done

@ViktorHofer
Copy link
Member

According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.

@mthalman
Copy link
Member Author

According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.

This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.

@ViktorHofer
Copy link
Member

This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.

Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.

@mthalman
Copy link
Member Author

Seems like a flaky test is blocking this.

@carlossanlop
Copy link
Member

I opened #92295 to track the test failure. Merging now.

@carlossanlop carlossanlop merged commit 3108db2 into dotnet:release/8.0 Sep 19, 2023
178 of 181 checks passed
@mthalman mthalman deleted the newtonsoft branch September 19, 2023 19:00
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants