-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Newtonsoft.Json from 13.0.1 to 13.0.3 #92277
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency. This was missed as part of the initial set of work to update all repos to 13.0.3. Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
|
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlop - Yes, RC2 would be good |
Looks like there's a build issue though |
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it. |
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist). |
Done |
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in. |
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case. |
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier. |
Seems like a flaky test is blocking this. |
I opened #92295 to track the test failure. Merging now. |
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629