Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonsoft.Json version mismatch in stage 2 for release/8.0.1xx #3629

Closed
tmds opened this issue Sep 19, 2023 · 6 comments
Closed

Newtonsoft.Json version mismatch in stage 2 for release/8.0.1xx #3629

tmds opened this issue Sep 19, 2023 · 6 comments

Comments

@tmds
Copy link
Member

tmds commented Sep 19, 2023

When building stage 2 for release/8.0.1xx, our CI is failing to build runtime due to a Newtonsoft.Json version mismatch:

    /home/tester/dotnet/src/runtime/artifacts/source-build/self/src/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj : error NU1605: Warning As Error: Detected package downgrade: Newtonsoft.Json from 13.0.3 to 13.0.1. Reference the package directly from the project to select a different version.  [/home/tester/dotnet/src/runtime/artifacts/source-build/self/src/Build.proj]
    /home/tester/dotnet/src/runtime/artifacts/source-build/self/src/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj : error NU1605:  Microsoft.NETCore.Platforms_temp -> NuGet.ProjectModel 6.8.0-rc.32767 -> NuGet.DependencyResolver.Core 6.8.0-rc.32767 -> NuGet.Protocol 6.8.0-rc.32767 -> NuGet.Packaging 6.8.0-rc.32767 -> Newtonsoft.Json (>= 13.0.3)  [/home/tester/dotnet/src/runtime/artifacts/source-build/self/src/Build.proj]
    /home/tester/dotnet/src/runtime/artifacts/source-build/self/src/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj : error NU1605:  Microsoft.NETCore.Platforms_temp -> Newtonsoft.Json (>= 13.0.1) [/home/tester/dotnet/src/runtime/artifacts/source-build/self/src/Build.proj]
      Failed to restore /home/tester/dotnet/src/runtime/artifacts/source-build/self/src/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj (in 2.68 sec).
    
    Build FAILED.

The artifacts tarball from the stage 1 build contains 13.0.3, but the build prefers to have 13.0.1.

cc @MichaelSimons @mthalman @omajid

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

@mthalman - Have you encountered this with your work to upgrade all repos to Newtonsoft 13.0.3? Is this something you have already fixed?

@mthalman
Copy link
Member

@tmds - Can you provide a binlog? I see that runtime still has a reference to 13.0.1 but in our CI build, it's not attempting to load that version.

@mthalman
Copy link
Member

Even though Microsoft.NETCore.App has a reference to 13.0.1 it still uses 13.0.3 because Microsoft.NETCore.App also has a dependency on NuGet.Packaging.6.8.0-rc.32767 which has a dependency on 13.0.3. That's why our CI build hasn't ran into this. @tmds - It's not clear why your build is behaving differently. A binlog should provide clarity there.

@tmds
Copy link
Member Author

tmds commented Sep 19, 2023

My stage 2 build is now failing due to #3630.

@tmds
Copy link
Member Author

tmds commented Sep 22, 2023

My stage 2 build is now failing due to #3630.

I no longer see this issue on the stage 2 build, and the issue that I reported here also no longer reproduces.

@tmds tmds closed this as completed Sep 22, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants