-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Make CoreCLR/NativeAOT assembly compile with .subsections_via_symbols on Apple platforms #92544
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #92520 to release/8.0 /cc @jkotas @filipnavara Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Blocked - pending resolution of #92520 (comment) (I have not sent tactics email yet.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
Approved by Tactics via email, but will hold from merging until the feedback indicated by @jkotas is addressed.
|
That was already addressed in the PRs targeting main. Hence why the |
Yep, this is ready to be merged. |
Ah perfect, thanks for clarifying. I wanted to be completely sure. Merging now. |
Backport of #92520 to release/8.0
/cc @jkotas @filipnavara
Customer Impact
Building dotnet/runtime repo or building native AOT apps with recently released XCode 15 toolchain produces binaries with broken exception handling.
Testing
The fix validated by @vcsjones : #92297 (comment)
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.