Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add Native AOT Pri0 test leg #91373

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 31, 2023

Backport of #89421 to release/8.0

/cc @MichalStrehovsky

Customer Impact

Adds an extra test leg so that we can ensure higher quality of the release.

Testing

Test only change.

Risk

Makes the CI infrastructure more busy.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 31, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #89421 to release/8.0

/cc @MichalStrehovsky

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@MichalStrehovsky
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

Infra change, (tell mode). Approved.

@agocke / @hoyosjs can you please provide your code review sign off?

@carlossanlop
Copy link
Member

There are runtime-extra-platforms NativeAOT failures. Is any of them related to this, @MichalStrehovsky ?

@agocke
Copy link
Member

agocke commented Aug 31, 2023

No, these are libs failures. Looks like something might be causing the compiler to crash. I'll try to repro.

@agocke
Copy link
Member

agocke commented Aug 31, 2023

Oh, exit code 137 is OOM kill

@carlossanlop
Copy link
Member

Should I wait for a fix to get included, or is this good to merge, @agocke?

@agocke
Copy link
Member

agocke commented Sep 2, 2023

Good to merge, this is a preexisting issue

@carlossanlop carlossanlop merged commit ef67ba8 into release/8.0 Sep 11, 2023
232 of 251 checks passed
@carlossanlop carlossanlop deleted the backport/pr-89421-to-release/8.0 branch September 11, 2023 23:09
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants