[release/8.0-rc2] Do not call SignalSession on invalid session IDs #92444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsBackport of #92431 to release/8.0-rc2 /cc @davmason Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tommcdon
approved these changes
Sep 21, 2023
6 tasks
jeffschwMSFT
approved these changes
Sep 22, 2023
jeffschwMSFT
added
the
Servicing-consider
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92431 to release/8.0-rc2
/cc @davmason
Customer Impact
Since we call
EventPipeInternal.SignalSessionon eachSetStopDispatchTaskcall, we can end up calling it on a session that is in the middle of freeing. If we catch it at just the right time the session could still be active but with a freed handle for the wait event. We have seen asserts in testing, but it would also be possible to AV in release builds.Testing
Running the failing test in a loop.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.