Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Bump version to GA #92305

Merged
merged 3 commits into from
Sep 21, 2023
Merged

[release/8.0] Bump version to GA #92305

merged 3 commits into from
Sep 21, 2023

Conversation

carlossanlop
Copy link
Member

Here's what we did last year: #75649

@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Here's what we did last year: #75649

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: 8.0.0

@carlossanlop
Copy link
Member Author

@lewing @steveisok @radical The failure is mono/wasm related. Can you please take a look when you get a chance?:

.packages/microsoft.dotnet.build.tasks.packaging/8.0.0-beta.23463.1/build/Packaging.targets(1217,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) System.Exception: The package ID 'Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rtm.' contains invalid characters. Examples of valid package IDs include 'MyPackage' and 'MyPackage.Sample'.
   at NuGet.Packaging.Manifest.Validate(Manifest manifest)
   at NuGet.Packaging.Manifest.Save(Stream stream, Int32 minimumManifestVersion, Boolean generateBackwardsCompatible)
   at Microsoft.DotNet.Build.Tasks.Packaging.GenerateNuSpec.Save(Manifest manifest, Stream stream) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateNuSpec.cs:line 159
   at Microsoft.DotNet.Build.Tasks.Packaging.GenerateNuSpec.WriteNuSpecFile() in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateNuSpec.cs:line 127
   at Microsoft.DotNet.Build.Tasks.Packaging.GenerateNuSpec.Execute() in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateNuSpec.cs:line 98

@carlossanlop
Copy link
Member Author

carlossanlop commented Sep 19, 2023

Oh, I think you're fixing it with #92306

@carlossanlop
Copy link
Member Author

Oh, I think you're fixing it with #92306

Wait, no. That PR was for RC2. This one is for release/8.0. Why is this one failing?

@steveisok
Copy link
Member

Oh, I think you're fixing it with #92306

Wait, no. That PR was for RC2. This one is for release/8.0. Why is this one failing?

There were a few flow PR's needing merged into release/8.0 in emsdk. That's been done and may resolve this once the internal build completes.

@lewing
Copy link
Member

lewing commented Sep 20, 2023

@steveisok this one looks like it needs the release/rtm check

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 20, 2023
@carlossanlop
Copy link
Member Author

All green now!

@carlossanlop carlossanlop merged commit a419d35 into release/8.0 Sep 21, 2023
181 checks passed
@carlossanlop carlossanlop deleted the bump8toGA branch September 21, 2023 19:43
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants