Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] helix/windows tests issues tracking issue #52138

Closed
Tracked by #52143
radekdoulik opened this issue Apr 30, 2021 · 7 comments
Closed
Tracked by #52143

[wasm] helix/windows tests issues tracking issue #52138

radekdoulik opened this issue Apr 30, 2021 · 7 comments
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono tracking This issue is tracking the completion of other related issues.
Milestone
8.0.0

Comments

@radekdoulik
Copy link
Member

radekdoulik commented Apr 30, 2021 •
edited
Loading

#51951 runs the normal scenario tests on windows/helix.

These tests are failing:

Browser:
@radekdoulik radekdoulik self-assigned this Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

#51951 runs the normal scenario tests on windows/helix.

These tests are failing:

Author: radekdoulik
Assignees: radekdoulik
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2021
@lewing lewing added tracking This issue is tracking the completion of other related issues. and removed untriaged New issue has not been triaged by the area owner labels Apr 30, 2021
@radical radical mentioned this issue Apr 30, 2021
Closed
15 tasks
@radical
Copy link
Member

radical commented Apr 30, 2021

Can we enable the other tests?

@lewing
Copy link
Member

lewing commented May 1, 2021

It is very interesting how sensitive these tests are to the build host vs the runtime host

@lewing
Copy link
Member

lewing commented May 1, 2021

Can we enable the other tests?

We need to check on capacity.

@radical
Copy link
Member

radical commented May 1, 2021

Can we enable the other tests?

We need to check on capacity.

Start with a couple then? System.buffers?

@radekdoulik
Copy link
Member Author

Can we enable the other tests?

My plan was to get it working on helix (it uses the normal scenario, so it runs a lot of things already, interpreter only). It is now relatively good - we have these 10 failures instead of cca 110 in the beginning, when I started and pretty much nothing worked on helix :-)

So I think we can enable AOT now, see if there are any additional issues and then fix them along the way. I have already opened PR's for 2 of these.

@radekdoulik
Copy link
Member Author

It is very interesting how sensitive these tests are to the build host vs the runtime host

Yes :-) OTOH, some of these are similar issues, some related to files (directory separators?), some to line endings (LF vs CRLF) and then there's either timeout issue or something else, maybe related to docker or localization.

@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 5, 2021
@radekdoulik radekdoulik mentioned this issue May 10, 2021
Merged
radekdoulik added a commit that referenced this issue May 12, 2021
@radekdoulik
[wasm] Make windows wasm build run tests on helix (#51951)
1dc5010 
Some of the tests were disabled for now: #52138

* Make windows wasm build run tests on helix

* Update sendtohelixhelp.proj

* More changes for wasm/windows

* More changes to run on windows

* Fix xharness output paths

* Disable failing tests

* Use ProjectExclusions when adding wasm samples

* Restore platform matrix

* Disable the tests only on windows/helix

Also make the new property groups conditional to improve perf
radekdoulik added a commit to radekdoulik/runtime that referenced this issue May 12, 2021
@radekdoulik
Run disabled wasm tests on windows
4c02198 
Context: dotnet#52138
@radekdoulik radekdoulik mentioned this issue May 12, 2021
Closed
@radekdoulik radekdoulik modified the milestones: 6.0.0, 7.0.0 Aug 13, 2021
@radekdoulik radekdoulik modified the milestones: 7.0.0, 8.0.0 Jul 26, 2022
@am11 am11 mentioned this issue Oct 28, 2022
Merged
@lewing lewing closed this as completed Jul 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono tracking This issue is tracking the completion of other related issues.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@radical @lewing @radekdoulik @ViktorHofer