-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] System.CodeDom tests failing on windows #52107
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSimilar to #52106 it has these issues:
Example failure:
The timeout is weird, as locally it only takes about 5s to run.
|
dotnet-issue-labeler
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Apr 30, 2021
ViktorHofer
removed
the
untriaged
New issue has not been triaged by the area owner
label
May 5, 2021
radekdoulik
changed the title
[wasm] System..CodeDom tests failing on windows
[wasm] System.CodeDom tests failing on windows
May 10, 2021
radekdoulik
added a commit
to radekdoulik/runtime
that referenced
this issue
May 10, 2021
Fixes: dotnet#52107 When running `System.CodeDom` tests on windows and targeting `Browser`, the line ending differs between host and target systems. Add helper `LineEndingsHelper.Normalize` method to update expected strings. The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`. https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
May 10, 2021
radekdoulik
added a commit
that referenced
this issue
May 12, 2021
Fixes: #52107 When running `System.CodeDom` tests on windows and targeting `Browser`, the line ending differs between host and target systems. Add helper `LineEndingsHelper.Normalize` method to update expected strings. The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`. https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51
ghost
removed
the
in-pr
There is an active PR which will close this issue when it is merged
label
May 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Similar to #52106 it has these issues:
Example failure:
The timeout is weird, as locally it only takes about 5s to run.
The text was updated successfully, but these errors were encountered: