[tests] Fix CRLF issues in M.E.Http #52707
Conversation
Fixes: dotnet#52135 When running `Microsoft.Extensions.Http` tests on windows and targeting `Browser`, the line ending differs between host and target systems. Use helper `LineEndingsHelper.Normalize` method to update expected strings. The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`. https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes: #52135 When running The
|
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes: #52135 When running The
|
|
@radekdoulik what is the status of this PR? Is anything blocking you? |
I didn't notice it was approved, thanks! I will fix the issue link. |
|
@radekdoulik if it is updated, can you please merge it? |
|
Ops, I keep forgetting about it. |
ghost
locked as resolved and limited conversation to collaborators
Fixes: #52008
When running
Microsoft.Extensions.Httptests on windows andtargeting
Browser, the line ending differs between host and targetsystems. Use helper
LineEndingsHelper.Normalizemethod to updateexpected strings.
The
BrowserEnvironment.NewLine is\n, while windows use\r\n.runtime/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs
Line 51 in 5bd0edf