Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] System.Xml.Xsl.XslCompiledTransformApi tests fail on windows/helix #52136

Closed
radekdoulik opened this issue Apr 30, 2021 · 6 comments · Fixed by #63623
Closed

[wasm] System.Xml.Xsl.XslCompiledTransformApi tests fail on windows/helix #52136

radekdoulik opened this issue Apr 30, 2021 · 6 comments · Fixed by #63623
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Milestone
7.0.0

Comments

@radekdoulik
Copy link
Member

Similar issue to System.IO.Compression tests:

[15:59:49] fail: [FAIL] System.Xml.Tests.CTransformRegressionTest.RegressionTest1(xslInputType: URI, readerType: XmlValidatingReader, outputType: Stream, navType: XPathDocument)
[15:59:49] info: System.IO.FileNotFoundException : Could not find file '/TestFiles/TestData/XsltApiV2/Straße.xml'.
[15:59:49] info:    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
[15:59:49] info:    at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
[15:59:49] info:    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
[15:59:49] info:    at System.IO.Strategies.FileStreamHelpers.OpenHandle(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options)
[15:59:49] info:    at System.IO.Strategies.Net5CompatFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
[15:59:49] info:    at System.IO.File.Open(String path, FileMode mode, FileAccess access, FileShare share)
[15:59:49] info:    at System.IO.File.Open(String path, FileMode mode)
[15:59:49] info:    at System.Xml.Tests.CTransformRegressionTest.RegressionTest1(XslInputType xslInputType, ReaderType readerType, OutputType outputType, NavType navType)
[15:59:49] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[15:59:49] info: Finished:    System.Xml.Xsl.XslCompiledTransformApi.Tests.dll
[15:59:49] info: 
[15:59:49] info: === TEST EXECUTION SUMMARY ===
[15:59:49] info: Total: 1615, Errors: 0, Failed: 1, Skipped: 29, Time: 22.261575s
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Similar issue to System.IO.Compression tests:

[15:59:49] fail: [FAIL] System.Xml.Tests.CTransformRegressionTest.RegressionTest1(xslInputType: URI, readerType: XmlValidatingReader, outputType: Stream, navType: XPathDocument)
[15:59:49] info: System.IO.FileNotFoundException : Could not find file '/TestFiles/TestData/XsltApiV2/Straße.xml'.
[15:59:49] info:    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
[15:59:49] info:    at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
[15:59:49] info:    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
[15:59:49] info:    at System.IO.Strategies.FileStreamHelpers.OpenHandle(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options)
[15:59:49] info:    at System.IO.Strategies.Net5CompatFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
[15:59:49] info:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
[15:59:49] info:    at System.IO.File.Open(String path, FileMode mode, FileAccess access, FileShare share)
[15:59:49] info:    at System.IO.File.Open(String path, FileMode mode)
[15:59:49] info:    at System.Xml.Tests.CTransformRegressionTest.RegressionTest1(XslInputType xslInputType, ReaderType readerType, OutputType outputType, NavType navType)
[15:59:49] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[15:59:49] info: Finished:    System.Xml.Xsl.XslCompiledTransformApi.Tests.dll
[15:59:49] info: 
[15:59:49] info: === TEST EXECUTION SUMMARY ===
[15:59:49] info: Total: 1615, Errors: 0, Failed: 1, Skipped: 29, Time: 22.261575s
Author: radekdoulik
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radekdoulik radekdoulik mentioned this issue Apr 30, 2021
Closed
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label May 5, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 5, 2021
@pavelsavara
Copy link
Member

The file is in the emscripten VFS

@lewing lewing modified the milestones: 6.0.0, 7.0.0 Jul 16, 2021
@lewing
Copy link
Member

lewing commented Jul 31, 2021 •
edited
Loading

given the name, is this an encoding issue when creating the vfs file path on windows?

@steveisok
Copy link
Member

The tests are assuming to be a relative path below where the app is executing from. Looks like the path is absolute /TestFiles/TestData/XsltApiV2/Straße.xml for whatever reason.

@pavelsavara
Copy link
Member

pavelsavara commented Jan 12, 2022 •
edited
Loading

This also fails src\libraries\System.Private.Xml\tests\Xslt\XsltCompiler\XsltCompiler.Tests.csproj because V8 shell doesn't support unicode filenames
https://bugs.chromium.org/p/v8/issues/detail?id=12541

@pavelsavara pavelsavara mentioned this issue Jan 12, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 12, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2022
@pavelsavara
Copy link
Member

Underlying issue was fixed https://chromium.googlesource.com/v8/v8/+/2fe25c602c9f90d4a9db9a97b556e6e7f42476fc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Load assets earlier pavelsavara/runtime
5 participants
@lewing @pavelsavara @steveisok @radekdoulik @ViktorHofer