Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Use '/' directory separator in .blat #52066

Merged
merged 2 commits into from
May 3, 2021

Conversation

radekdoulik
Copy link
Member

Fixes: #52007

We were using host system PathSeparators, which lead to problems when
building the app on windows.

This change makes the System.Runtime library tests pass on windows.

Fixes: dotnet#52007

We were using host system `PathSeparator`s, which lead to problems when
building the app on windows
@radekdoulik radekdoulik added arch-wasm WebAssembly architecture area-Interop-mono labels Apr 29, 2021
@radekdoulik radekdoulik requested review from lewing and tqiu8 April 29, 2021 17:32
@ghost
Copy link

ghost commented Apr 29, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #52007

We were using host system PathSeparators, which lead to problems when
building the app on windows.

This change makes the System.Runtime library tests pass on windows.

Author: radekdoulik
Assignees: -
Labels:

arch-wasm, area-Interop-mono

Milestone: -

Copy link
Contributor

@tqiu8 tqiu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Paths causing problems again on windows.

@radekdoulik radekdoulik merged commit d582900 into dotnet:main May 3, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Interop-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] System.Runtime tests fail on windows, timezone issues
4 participants