Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] System.ServiceModel.Syndication tests fail on windows/helix #52135

Closed
radekdoulik opened this issue Apr 30, 2021 · 1 comment · Fixed by #52705
Closed

[wasm] System.ServiceModel.Syndication tests fail on windows/helix #52135

radekdoulik opened this issue Apr 30, 2021 · 1 comment · Fixed by #52705
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Milestone
6.0.0

Comments

@radekdoulik
Copy link
Member

Many failing tests like this:

[15:56:43] fail: [FAIL] System.ServiceModel.Syndication.Tests.SyndicationItemFormatterTests.WriteElementExtensions_Person_Success(version: "version")
[15:56:43] info: System.NotSupportedException : -- Expected -
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info: 
[15:56:43] info:     <Value>10</Value>
[15:56:43] info: 
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: 
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info: 
[15:56:43] info:     <Value>11</Value>
[15:56:43] info: 
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: -- Actual -
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info:     <Value>10</Value>
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info:     <Value>11</Value>
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: 
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.CompareHelper.AssertEqualLongString(String expected, String actual)
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.CompareHelper.AssertEqualWriteOutput(String expected, Action`1 writeFunction)
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.SyndicationItemFormatterTests.WriteElementExtensions_Person_Success(String version)
[15:56:43] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[15:56:43] info: Finished:    System.ServiceModel.Syndication.Tests.dll
[15:56:43] info: 
[15:56:43] info: === TEST EXECUTION SUMMARY ===
[15:56:43] info: Total: 1308, Errors: 0, Failed: 110, Skipped: 0, Time: 9.0888959s
@ghost
Copy link

ghost commented Apr 30, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Many failing tests like this:

[15:56:43] fail: [FAIL] System.ServiceModel.Syndication.Tests.SyndicationItemFormatterTests.WriteElementExtensions_Person_Success(version: "version")
[15:56:43] info: System.NotSupportedException : -- Expected -
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info: 
[15:56:43] info:     <Value>10</Value>
[15:56:43] info: 
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: 
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info: 
[15:56:43] info:     <Value>11</Value>
[15:56:43] info: 
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: -- Actual -
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info:     <Value>10</Value>
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: <SyndicationItemFormatterTests.ExtensionObject xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel.Syndication.Tests">
[15:56:43] info:     <Value>11</Value>
[15:56:43] info: </SyndicationItemFormatterTests.ExtensionObject>
[15:56:43] info: 
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.CompareHelper.AssertEqualLongString(String expected, String actual)
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.CompareHelper.AssertEqualWriteOutput(String expected, Action`1 writeFunction)
[15:56:43] info:    at System.ServiceModel.Syndication.Tests.SyndicationItemFormatterTests.WriteElementExtensions_Person_Success(String version)
[15:56:43] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[15:56:43] info: Finished:    System.ServiceModel.Syndication.Tests.dll
[15:56:43] info: 
[15:56:43] info: === TEST EXECUTION SUMMARY ===
[15:56:43] info: Total: 1308, Errors: 0, Failed: 110, Skipped: 0, Time: 9.0888959s
Author: radekdoulik
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2021
@radekdoulik radekdoulik mentioned this issue Apr 30, 2021
Closed
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label May 5, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 5, 2021
radekdoulik added a commit to radekdoulik/runtime that referenced this issue May 13, 2021
@radekdoulik
[tests] Fix CRLF issues in SM.Syndication
0305ee9 
Fixes: dotnet#52135

When running `System.ServiceModel.Syndication` tests on windows and
targeting `Browser`, the line ending differs between host and target
systems. Use helper `LineEndingsHelper.Normalize` method to update
expected strings.

The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`.
https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51

Also set `BrowserHost` property for the build as well. It is also used
in `src/libraries/tests.proj`.
@radekdoulik radekdoulik mentioned this issue May 13, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 13, 2021
radekdoulik added a commit to radekdoulik/runtime that referenced this issue May 13, 2021
@radekdoulik
[tests] Fix CRLF issues in M.E.Http
fddb023 
Fixes: dotnet#52135

When running `Microsoft.Extensions.Http` tests on windows and
targeting `Browser`, the line ending differs between host and target
systems. Use helper `LineEndingsHelper.Normalize` method to update
expected strings.

The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`.
https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51
@radekdoulik radekdoulik mentioned this issue May 13, 2021
Merged
radekdoulik added a commit that referenced this issue May 13, 2021
@radekdoulik
[tests] Fix CRLF issues in SM.Syndication (#52705)
8013221 
Fixes: #52135

When running `System.ServiceModel.Syndication` tests on windows and
targeting `Browser`, the line ending differs between host and target
systems. Use helper `LineEndingsHelper.Normalize` method to update
expected strings.

The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`.
https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51

Also set `BrowserHost` property for the build as well. It is also used
in `src/libraries/tests.proj`.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[tests] Fix CRLF issues in SM.Syndication radekdoulik/runtime
2 participants
@radekdoulik @ViktorHofer