[tests] Fix CRLF issues in SM.Syndication #52705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#52135 When running `System.ServiceModel.Syndication` tests on windows and targeting `Browser`, the line ending differs between host and target systems. Use helper `LineEndingsHelper.Normalize` method to update expected strings. The `Browser` Environment.NewLine is `\n`, while windows use `\r\n`. https://github.com/dotnet/runtime/blob/5bd0edfe860e41bdfd690d3743e730594307292e/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs#L51 Also set `BrowserHost` property for the build as well. It is also used in `src/libraries/tests.proj`.
radekdoulik
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes: #52135 When running The Also set
|
lewing
approved these changes
May 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52135
When running
System.ServiceModel.Syndicationtests on windows andtargeting
Browser, the line ending differs between host and targetsystems. Use helper
LineEndingsHelper.Normalizemethod to updateexpected strings.
The
BrowserEnvironment.NewLine is\n, while windows use\r\n.runtime/src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs
Line 51 in 5bd0edf
Also set
BrowserHostproperty for the build as well. It is also usedin
src/libraries/tests.proj.