-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DAP-13 #3436
Comments
For this portion of the work, I think no changes are needed:
N.B. there are a few places where we MUST check replay of a report, where Janus does not do so because we implement the check at an earlier point in the protocol. I don't think we should make functional changes to Janus; we might consider an editorial change to DAP to say something like "Report replay MUST be resolved if it has not already been resolved." |
I verified that we will always reject reports that are outside of the task's valid time window (i.e. |
I removed the (optional) indication of unknown extension types by the Leader, filing #3505 instead. |
I filed #3510 to add support for Prio3MultihotCountVec; it's not required for a compliant DAP-13 implementation, but there is little reason (other than prioritization) not to support it. |
Once #3564 lands, Janus should be able to interop with any DAP-13 aggregator, whether it is using synchronous or asynchronous aggregation. We should still implement Helper async aggregation (which is my next task), but we should now be DAP-13 complete. (I say "should be" rather than "are" because there is no other DAP-13 aggregator to test against just yet, so we cannot fully validate our implementation.) |
DAP-13: https://www.ietf.org/archive/id/draft-ietf-ppm-dap-13.html
From DAP-09, this will require (roughly):
max_batch_query_count
& the leader-selectedby_batch_id
query. (DAP-11, PR, [1])max_batch_size
. (DAP-12, PR)PrepareError
values. (DAP-12, PR)Query
,BatchSelector
,PartialBatchSelector
to include length prefix. (DAP-13, PR)[1] Do not remove the
part_batch_selector
field, as it is restored in a later change.[2] This may not require changes, but we should validate that Janus implements the specified behavior.
[3] This depends on a release of
libprio-rs
implementing VDAF-13 being available.The text was updated successfully, but these errors were encountered: