Update PrepareError allocations (*) #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wherever we have extension points in the protocol, we should reserve a `0` for testing purposes. We've done this for upload extensions and batch modes, but failed to do so for prepare errors. This is relevant because future DAP extensions might need to register prepare errors. Reserve `0` and shift all remaining codepoints by `1`, except for those following `6`, which was allocated in a previous draft but earmarked for deletion in a future draft.
cjpatton
requested review from
tgeoghegan,
branlwyd,
ekr and
chris-wood
as code owners
tgeoghegan
approved these changes
Oct 9, 2024
branlwyd
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever we have extension points in the protocol, we should reserve a
0for testing purposes. We've done this for upload extensions and batch modes, but failed to do so for prepare errors. This is relevant because future DAP extensions might need to register prepare errors.Reserve
0and shift all remaining codepoints by1, except for those following6, which was allocated in a previous draft but earmarked for deletion in a future draft.