Switch to VDAF-13. #3504
Merged
Switch to VDAF-13. #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I currently pin to a specific commit in libprio-rs tracking the VDAF-13 implementation, as the implementation is currently ongoing. I am fairly confident that the only breaking interface changes have already been implemented: there is a new "application context string", which is computed as the concatenation of hte current DAP draft in use & the task ID. Also, bump the version tag while I'm at it, since I touched it anyway.
|
Part of #3436. |
inahga
approved these changes
Nov 22, 2024
| /// with the task ID. | ||
| pub fn vdaf_application_context( | ||
| task_id: &TaskId, | ||
| ) -> [u8; DAP_VERSION_IDENTIFIER.len() + TaskId::LEN] { |
There was a problem hiding this comment.
TIL you can do const operations in this spot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently pin to a specific commit in libprio-rs tracking the VDAF-13 implementation, as the implementation is currently ongoing. I am fairly confident that the only breaking interface changes have already been implemented: there is a new "application context string", which is computed as the concatenation of hte current DAP draft in use & the task ID.
Also, bump the version tag while I'm at it, since I touched it anyway.