Remove multi-collection. #3481
Merged
Remove multi-collection. #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
added
the
allow-changed-migrations
branlwyd
force-pushed
the
bran/no-multi-collection
branch
from
d3a0c10 to
3264784
Compare
|
Part of #3436. |
branlwyd
force-pushed
the
bran/no-multi-collection
branch
from
3264784 to
9591330
Compare
|
(apologies, a couple of force-pushes to clean up formatting & a few merge issues with the rebase onto the renaming PR) |
DAP-11 removed the ability to collect a batch more than once (with differing aggregation parameters). This commit also includes related changes to a few messages, and removes the max_batch_query_count task parameter.
branlwyd
force-pushed
the
bran/no-multi-collection
branch
from
9591330 to
cbef95e
Compare
inahga
approved these changes
Nov 14, 2024
Comment on lines
-196
to
-211
|
|
||
| /// Batch identifier, encoded with base64url | ||
| #[clap( | ||
| long, | ||
| conflicts_with_all = ["batch_interval_start", "batch_interval_duration", "current_batch"], | ||
| help_heading = "Collect Request Parameters (Leader Selected)", | ||
| )] | ||
| batch_id: Option<BatchId>, | ||
| /// Have the aggregator select a batch that has not yet been collected | ||
| #[clap( | ||
| long, | ||
| action = ArgAction::SetTrue, | ||
| conflicts_with_all = ["batch_interval_start", "batch_interval_duration", "batch_id"], | ||
| help_heading = "Collect Request Parameters (Leader Selected)", | ||
| )] | ||
| current_batch: bool, |
There was a problem hiding this comment.
Hmm, so now without explicit --batch-interval-{start,duration}, we automatically assume we're operating on a fixed size task.
I suppose that's fine. Maybe we can think of a better way to clean up this CLI for this, but I don't think its important.
There was a problem hiding this comment.
Yep, that's correct. I thought about this for a bit & came up with the same conclusion you did. We could introduce something like a --leader-selected flag to indicate a leader-selected query, but I'm not fully sure it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAP-11 removed the ability to collect a batch more than once (with differing aggregation parameters). This commit also includes related changes to a few messages, and removes the max_batch_query_count task parameter.