Remove support for Poplar1. #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAP-11 removed the ability to collect a batch more than once (with differing aggregation parameters). This commit also includes related changes to a few messages, and removes the max_batch_query_count task parameter.
branlwyd
force-pushed
the
bran/adios-poplar-1
branch
from
207a019 to
789bcaf
Compare
branlwyd
force-pushed
the
bran/adios-poplar-1
branch
2 times, most recently
from
6430a9d to
1ab5018
Compare
DAP-11 removed multi-collection and, with it, the ability to usefully use Poplar1. This commit makes the following changes: * Application-level support for Poplar1 is removed. * Unit tests which used Poplar1 now use libprio-rs' dummy::Vdaf. * Introduce a test-only ability to configure the fake dummy::Vdaf for taskprov, required to migrate some taskprov unit tests.
branlwyd
force-pushed
the
bran/adios-poplar-1
branch
from
1ab5018 to
44e5e1c
Compare
inahga
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAP-11 removed multi-collection and, with it, the ability to usefully use Poplar1. This commit makes the following changes: