Rename several concepts for DAP-13. #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
added
the
allow-changed-migrations
|
I also surveyed renaming "upload extension" to "report extension" -- it turns out there is nothing to change here. In source code, we always refer to this concept as simply "extensions". Part of #3436. |
branlwyd
force-pushed
the
bran/dap-13-rename
branch
from
c780b60 to
41c7887
Compare
branlwyd
force-pushed
the
bran/dap-13-rename
branch
from
41c7887 to
300519e
Compare
|
(rebased w/ #3469) |
divergentdave
approved these changes
Nov 13, 2024
inahga
approved these changes
Nov 13, 2024
Comment on lines
+88
to
+92
| R: Backoff + Clone + Send + Sync + 'static, | ||
| { | ||
| pub fn new( | ||
| http_client: reqwest::Client, | ||
| backoff: B, | ||
| backoff: R, |
There was a problem hiding this comment.
nit: I think this is a sed error, Backoff still ought to be B.
There was a problem hiding this comment.
Ah, I renamed the B: Backoff types to R (for retry) instead, since they conflicted with the new B: BatchMode types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: