Implement task start time. #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #3436. |
branlwyd
added
the
allow-changed-migrations
|
See also: ietf-wg-ppm/draft-ietf-ppm-dap#634 |
inahga
approved these changes
Nov 22, 2024
|
Nevermind, it's not arguable, behavior is in the spec https://ietf-wg-ppm.github.io/draft-ietf-ppm-dap/draft-ietf-ppm-dap.html#name-input-share-validation 😄 |
Note that DAP specifies the parameters as "task start time" and "task duration", rather than Janus' "task start time" and "task end time". Janus implements things this way so that either parameter can be left unspecified.
branlwyd
force-pushed
the
bran/task-start-time
branch
from
64210ac to
5f13168
Compare
|
(force-push to rerun the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that DAP specifies the parameters as "task start time" and "task duration", rather than Janus' "task start time" and "task end time". Janus implements things this way so that either parameter can be left unspecified.
I leave taskprov configuration for a later commit, which will update taskprov functionality to match the latest specification.