Require rejection of reports outside of the task's validity window #628
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
tgeoghegan,
branlwyd,
ekr and
chris-wood
as code owners
|
@branlwyd let's merge by 2024/10/31 unless we get push back. |
tgeoghegan
approved these changes
Oct 25, 2024
branlwyd
approved these changes
Oct 25, 2024
cjpatton
force-pushed
the
cjpatton/625
branch
from
6acddd9 to
9de7431
Compare
If a report's timestamp is before `tast_start` or after `task_start + task_duration`, then Aggregators MUST reject it. Co-authored-by: Brandon Pitman <[email protected]>
cjpatton
force-pushed
the
cjpatton/625
branch
from
9de7431 to
310adbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #625.
If a report's timestamp is before
tast_startor aftertask_start + task_duration, then Aggregators MUST reject it.