Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartC compiles -0.0 to 0 in optimized mode. #146

Closed
floitschG opened this issue Oct 17, 2011 · 3 comments
Closed

DartC compiles -0.0 to 0 in optimized mode. #146

floitschG opened this issue Oct 17, 2011 · 3 comments

Comments

@floitschG
Copy link
Contributor

DartC compiles -0.0 to 0 in optimized mode.

main() { print(-0.0); }
is compiled to:
...
$_Logger$Dart$print$0named$$(0)
...

This was produced with:
dartc --human-readable-output --optimize ...

r466

@DartBot
Copy link

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]


Filed: http://code.google.com/p/closure-compiler/issues/detail?id=582

@DartBot
Copy link

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]


Set owner to [email protected].

@DartBot
Copy link

DartBot commented Oct 18, 2011

This comment was originally written by [email protected]


r511


Added Fixed label.

nex3 pushed a commit that referenced this issue Aug 31, 2016
there are two basic strategies to fix: we either provide globals to the renamer, or it determines them based on use. I went with the second approach, as it fits more naturally with the current code generator.

[email protected]

Review URL: https://codereview.chromium.org/1099813006
copybara-service bot pushed a commit that referenced this issue May 24, 2022
Merges shelf_router and shelf_router_generator to the shelf mono repo.

Changes:
```
> git log --format="%C(auto) %h %s" fadca32..05f4260
 https://dart.googlesource.com/shelf.git/+/05f4260 Merge remote-tracking branch 'origin/HEAD' into jonasfj/master
 https://dart.googlesource.com/shelf.git/+/4f4fa0a Fix pubspec repository for shelf_web_socket (#233)
 https://dart.googlesource.com/shelf.git/+/d4ff2ae Update READMEs, adjust mono_pkg.yaml
 https://dart.googlesource.com/shelf.git/+/d6efa6e Merge in shelf_router / shelf_router_generator.
 https://dart.googlesource.com/shelf.git/+/6d1f24d Add root readme (#229)
 https://dart.googlesource.com/shelf.git/+/d23cc89 Use the same lints across all packages (#228)
 https://dart.googlesource.com/shelf.git/+/3fdddb1 Merge CI steps across packages (#226)
 https://dart.googlesource.com/shelf.git/+/9b5a08a Upgrade mono_repo (#174)
 https://dart.googlesource.com/shelf.git/+/f04e60f Upgrade mono_repo (#169)
 https://dart.googlesource.com/shelf.git/+/ef1c1ae Merge pull request #165 from isoos/upgrade
 https://dart.googlesource.com/shelf.git/+/dc49716 bump version
 https://dart.googlesource.com/shelf.git/+/07bf70a Upgrade dependencies in shelf_router_generator
 https://dart.googlesource.com/shelf.git/+/640915e fix: mount remove trailing slash requirement (#146)
 https://dart.googlesource.com/shelf.git/+/138ca19 Migrate to pkg:lints (#161)
 https://dart.googlesource.com/shelf.git/+/d2d026b Bump mono_repo to v5.0.1 (#150)
 https://dart.googlesource.com/shelf.git/+/ac19cc9 Fix a number of hints and lints (#151)
 https://dart.googlesource.com/shelf.git/+/9cb612a shelf_router_generator: latest dependencies (#152)
 https://dart.googlesource.com/shelf.git/+/4947570 Fix SDK constraints 2.12.0-0 to 2.12.0 (#148)
 https://dart.googlesource.com/shelf.git/+/8a11fee Merge pull request #147 from isoos/fix-rnf
 https://dart.googlesource.com/shelf.git/+/789824d Fix Router.routeNotFound to enable multiple read() calls on it.
 https://dart.googlesource.com/shelf.git/+/fac496f Introduce `routeNotFound` sentinel for shelf_router 1.1.0 (#141)
 https://dart.googlesource.com/shelf.git/+/33206e9 remove handler from app (#131)
 https://dart.googlesource.com/shelf.git/+/02c49f7 remove handler from app (#129)
 https://dart.googlesource.com/shelf.git/+/12cd917 shelf_router_generator: Latest dependencies, null safety (#122)
 https://dart.googlesource.com/shelf.git/+/074341b Update dependencies and enable/fix a number of lints (#120)
 https://dart.googlesource.com/shelf.git/+/b094c25 shelf_router_generator: Support null-safe dependencies (#113)
 https://dart.googlesource.com/shelf.git/+/f07b3ef Prepare shelf_router 1.0.0
 https://dart.googlesource.com/shelf.git/+/4c73784 Remove Router.handler while we're at it
 https://dart.googlesource.com/shelf.git/+/b18f808 Remove checkNotNull
 https://dart.googlesource.com/shelf.git/+/cce2ad9 Oops, forgot to set _params
 https://dart.googlesource.com/shelf.git/+/797da6e Avoid lazy in router entry
 https://dart.googlesource.com/shelf.git/+/a03e120 Make default handler customizable
 https://dart.googlesource.com/shelf.git/+/ed942ce No unecessary version bump, don't test on stable
 https://dart.googlesource.com/shelf.git/+/e18b186 [WIP] Migrate shelf_router to Dart null safety
 https://dart.googlesource.com/shelf.git/+/2a7cdd5 Upgrade package:analyzer in shelf_router_generator.
 https://dart.googlesource.com/shelf.git/+/6466748 Router: allow to mount a Handler (#86)
 https://dart.googlesource.com/shelf.git/+/91b695d Seal classes in shelf_router and prepare 0.7.3 (#85)
 https://dart.googlesource.com/shelf.git/+/4b4f15c Fix most of the hints - thanks to `dart fix` (#81)
 https://dart.googlesource.com/shelf.git/+/e99bcd0 Relax dependency constraint on analyzer for shelf_router_generator. (#79)
 https://dart.googlesource.com/shelf.git/+/2893dab Remove author from pubspec.yaml (#73)
 https://dart.googlesource.com/shelf.git/+/ac41ee2 Updated Travis configuration to allow packages to be tested in parallel jobs (#59)
 https://dart.googlesource.com/shelf.git/+/ad11925 Fix package:shelf_router to ensure GET handlers also respond to HEAD requests (#36)
 https://dart.googlesource.com/shelf.git/+/6a07835 Relax dependency on package:analyzer
 https://dart.googlesource.com/shelf.git/+/02e05dc Merge pull request #27 from jonasfj/relax-deps
 https://dart.googlesource.com/shelf.git/+/84fdb64 relax dependency constraint on analyzer
 https://dart.googlesource.com/shelf.git/+/aea3117 Merge pull request #19 from jonasfj/test-unrelated-annotation
 https://dart.googlesource.com/shelf.git/+/563e435 Test that unrelated annotations does not affect code-gen
 https://dart.googlesource.com/shelf.git/+/213d63a Prepare for releasing 0.7.2
 https://dart.googlesource.com/shelf.git/+/910173d Add generated files
 https://dart.googlesource.com/shelf.git/+/d0e21d5 Added test case for string escaping
 https://dart.googlesource.com/shelf.git/+/663de80 Fix issue #10, use raw strings
 https://dart.googlesource.com/shelf.git/+/3a9cd9f Fix travis tests
 https://dart.googlesource.com/shelf.git/+/c7c3baf Use Function instead of dynamic for handler in shelf_router
 https://dart.googlesource.com/shelf.git/+/592fd64 Fixed #6, using Function instead of dynamic
 https://dart.googlesource.com/shelf.git/+/26e888f Bumped shelf_router_generator dependencies
 https://dart.googlesource.com/shelf.git/+/7622006 Updated shelf_router_generator README
 https://dart.googlesource.com/shelf.git/+/3aa13ea Fixing nits for shelf-router
 https://dart.googlesource.com/shelf.git/+/279af5d Prepared shelf_router_generator for initial release
 https://dart.googlesource.com/shelf.git/+/eb39128 Removed dependency overrides from shelf_router, and updated changelog
 https://dart.googlesource.com/shelf.git/+/8baca2f Added authors and tool for publishing packages
 https://dart.googlesource.com/shelf.git/+/9d9d82c Added packages shelf_router and shelf_router_generator

```

Diff: https://dart.googlesource.com/shelf.git/+/fadca320b04689be9ec960013843a0d9ee6c4fc4~..05f42601d22c9bfe490ceda50e812f83b7d1de77/
Change-Id: Icb576d2a6005a036963508c7e32a65752dfb3033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245903
Commit-Queue: Nate Bosch <[email protected]>
Auto-Submit: Nate Bosch <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
Commit-Queue: Kevin Moore <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 24, 2023
…n, sse, stream_channel, test, tools, usage, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/0127813..ce650b0):
  ce650b0  2023-04-19  Nate Bosch  Regression test for error rejecting transaction (#230)

characters (https://github.com/dart-lang/characters/compare/ba8d557..b306414):
  b306414  2023-04-19  Lasse R.H. Nielsen  Add tools to update and generate tables and tests. (#72)

convert (https://github.com/dart-lang/convert/compare/8812e40..855aeac):
  855aeac  2023-04-10  Kevin Moore  Require Dart 2.19, fix override param name, update lints (#81)

crypto (https://github.com/dart-lang/crypto/compare/1cb1528..77491f5):
  77491f5  2023-04-19  Lasse R.H. Nielsen  Make `DigestSink` implement `Sink` (#146)

dartdoc (https://github.com/dart-lang/dartdoc/compare/a0755f5..8e8b36e):
  8e8b36e3  2023-04-19  Janice Collins  Fix up documentation on comment reference parser to align with wiki (#2851)
  b9178fce  2023-04-19  dependabot[bot]  Bump github/codeql-action from 2.2.11 to 2.2.12 (#3390)
  37b981c4  2023-04-19  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#3389)
  dadef24a  2023-04-10  dependabot[bot]  Bump github/codeql-action from 2.2.9 to 2.2.11 (#3386)
  dda699a7  2023-04-10  Sam Rawlins  Prepare mixin-like classes for Dart 3.0.0 (#3385)

intl (https://github.com/dart-lang/intl/compare/a958db0..5d65e38):
  5d65e38  2023-04-19  Moritz  Update README.md
  9972a89  2023-04-19  Moritz  Update README.md
  5c14faa  2023-04-18  Copybara-Service  Merge pull request #584 from dart-lang:fixDateFormattingUrl
  4ea644e  2023-04-17  Moritz  Merge branch 'master' into fixDateFormattingUrl
  b0d5687  2023-04-17  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#574)
  92149be  2023-04-17  Moritz  Merge branch 'master' into fixDateFormattingUrl
  5203d6e  2023-04-17  Googler  Internal change
  bab667f  2023-04-17  Moritz  Typo
  b0896b1  2023-04-17  Moritz  Fix bug
  43507e1  2023-04-14  Googler  Internal change
  d8844a0  2023-04-14  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#579)
  99ed16f  2023-04-13  Copybara-Service  Merge pull request #572 from dart-lang:adaptBrowserTest
  34e824c  2023-03-30  Moritz  Adapt test to browser CLDR update

markdown (https://github.com/dart-lang/markdown/compare/d437c85..5f98aea):
  5f98aea  2023-04-20  Jonas Finnemann Jensen  Throw, if `BlockSyntax.parseLines` loops indefinitely (#533)
  86ebc2c  2023-04-19  Zhiguang Chen  Fix `linkReferenceDefinitionPattern` (#532)

sse (https://github.com/dart-lang/sse/compare/11e83a0..f947c3d):
  f947c3d  2023-04-10  Kevin Moore  Require Dart 2.19, bump lints (#82)

stream_channel (https://github.com/dart-lang/stream_channel/compare/74646ea..71d4690):
  71d4690  2023-04-11  Tobe Osakwe  Add example/example.dart (#52)

test (https://github.com/dart-lang/test/compare/7832931..7fab079):
  7fab0792  2023-04-19  Oleh Prypin  Dart 3 compatibility: change `extends Iterator` to `implements Iterator` (#1997)
  8f7682a5  2023-04-18  Nate Bosch  Remove deprecation of test_api top level libraries (#1994)
  7151486c  2023-04-14  Simon Binder  Add support for Microsoft Edge (#1992)
  c1d686aa  2023-04-12  Parker Lougheed  Fix "Improvements" link in `package:checks` migration guide (#1991)

tools (https://github.com/dart-lang/tools/compare/545d7e1..5c9f45c):
  5c9f45c  2023-04-20  Elias Yishak  Move `dateStamp` getter to `utils.dart` (#83)

usage (https://github.com/dart-lang/usage/compare/0698711..f97752f):
  f97752f  2023-04-10  Devon Carew  update readme for deprecation (#192)

webdev (https://github.com/dart-lang/webdev/compare/7546291..8b42c95):
  8b42c950  2023-04-21  Anna Gringauze  Cleanup record types display (#2070)
  1cfb3bd6  2023-04-20  Elliott Brooks  Update CONTRIBUTING docs (#2097)
  941eda5b  2023-04-19  Elliott Brooks  Add a test to make sure proper release procedure is followed for `dwds` and `webdev` (#2095)
  2eb7c3ee  2023-04-17  Elliott Brooks  Add Github workflow for Dart Code Metrics (#2092)
  79a9bc9b  2023-04-17  Elliott Brooks  Fix DCM analyzer warnings (#2094)
  2a625039  2023-04-14  Elliott Brooks  Add `vm_service` git package dependency override (#2078)
  1fa19603  2023-04-12  Elliott Brooks  Add CI check to remind contributor to update CHANGELOG (#2090)
  c7bb19e1  2023-04-12  Elliott Brooks  Prevent PRs labeled `do-not-submit` from being merged (#2088)
  3781ef9b  2023-04-10  Elliott Brooks  Run mono_repo generate with version 6.5.3 (#2084)
  843890c6  2023-04-10  Anna Gringauze  Refactor record shape processing out of calculating record bound fields (#2074)

Change-Id: I4ce65f9f79d5086c33c575e57eff300216392510
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297800
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Moritz Sümmermann <[email protected]>
Commit-Queue: Moritz Sümmermann <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 8, 2023
…, typed_data

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/449478c..2a39574):
  2a395741  2023-06-07  Sam Rawlins  Seal mustachio nodes (#3433)
  d5bb24b2  2023-06-07  Sam Rawlins  Convert Tuples to Records and split a helper out from findCanonicalModelElementFor (#3432)

http_parser (https://github.com/dart-lang/http_parser/compare/1ef3e56..19466c0):
  19466c0  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#74)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/f17da61..fc45bec):
  fc45bec  2023-06-07  Polina Cherkasova  Break the leak tracker code to packages. (#80)

path (https://github.com/dart-lang/path/compare/f8d15c2..592505f):
  592505f  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#146)

pool (https://github.com/dart-lang/pool/compare/a10a0f9..c6b1b2c):
  c6b1b2c  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#71)

term_glyph (https://github.com/dart-lang/term_glyph/compare/9d8956f..4daa34e):
  4daa34e  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#39)

typed_data (https://github.com/dart-lang/typed_data/compare/693f48e..8d29573):
  8d29573  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#67)

Change-Id: I11fe765858ba970f13a2051abee34abf910f4698
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308161
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Aug 7, 2023
…st, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/97fc1a7..dfeda1a):
  dfeda1a  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.0.4 to 4.3.0 (#148)
  c341051  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#147)
  c1c8d1f  2023-08-01  Moritz  Update health.yaml (#146)
  31c5d21  2023-07-27  Devon Carew  misc updates to the label management tool (#145)

http (https://github.com/dart-lang/http/compare/4289e8b..7e9ed12):
  7e9ed12  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#1000)
  e8e35db  2023-07-31  Alex James  [java_http] send request body (#995)

mockito (https://github.com/dart-lang/mockito/compare/b421775..ff79de6):
  ff79de6  2023-08-04  Nate Bosch  Allow the latest package:analyzer

native (https://github.com/dart-lang/native/compare/f0dc3e9..0187d0e):
  0187d0e  2023-08-07  Daco Harkes  [native_assets_cli] Rename `Asset` `name` to `id` (#113)
  1b984c7  2023-08-07  Daco Harkes  [native_assets_cli] Replace `TypeError`s with `FormatException`s (#112)
  b2b26db  2023-08-07  Daco Harkes  [native_assets_builder] Stop throwing from BuildRunner (#108)
  c940ac8  2023-08-03  Daco Harkes  [native_assets_builder] return build dependencies (#107)
  63daab8  2023-08-03  Daco Harkes  [native_assets_builder] Fix dry run directory structure (#110)
  3f26f20  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#104)

protobuf (https://github.com/dart-lang/protobuf/compare/d9e8a31..217c030):
  217c030  2023-08-02  Ömer Sinan Ağacan  Avoid holding onto the buffer when parsing unknown length-delimited fields (#863)

shelf (https://github.com/dart-lang/shelf/compare/bd59ead..73edd2b):
  73edd2b  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#370)

sse (https://github.com/dart-lang/sse/compare/e241085..8cc5b11):
  8cc5b11  2023-08-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.0.0 to 2.1.1 (#86)

test (https://github.com/dart-lang/test/compare/92eb0f7..5d571d6):
  5d571d64  2023-08-03  Nate Bosch  Add --fail-fast flag (#2040)
  a9dcce29  2023-08-01  Nate Bosch  Rerun publish workflow on more PR changes (#2070)
  50d558b2  2023-08-01  dependabot[bot]  Bump github/codeql-action from 2.20.1 to 2.21.2 (#2071)
  9e124e9f  2023-07-31  Nate Bosch  Prepare to publish (#2069)

tools (https://github.com/dart-lang/tools/compare/af3fc99..f14bf2e):
  f14bf2e  2023-08-07  Elias Yishak  Remove unused NoOp classes (#138)
  a2aa1c3  2023-08-07  Devon Carew  add CI; update readme (#140)
  d424568  2023-08-06  Devon Carew  add usage docs to package:cli_config (#141)
  921611a  2023-08-03  Elias Yishak  Survey handler feature (#109)

Change-Id: Iee720272733822d11caf46adcae516f12f11abec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318801
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 1, 2023
…ocess, vector_math, web, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

native (https://github.com/dart-lang/native/compare/0051e78..b5827f3):
  b5827f3b  2023-11-29  Daco Harkes  [infra] Hide TODOs from problems view in VSCode (#837)
  17487159  2023-11-29  Liam Appelbe  [ffigen] Only use `objc_msgSend` variants on x64 (#836)
  50b6a783  2023-11-28  Ryan Macnak  [native_toolchain_c] Setup Android RISCV64 toolchain. (#165)
  aa58de61  2023-11-28  Daco Harkes  [native] Bump deps (#834)
  6cf4c783  2023-11-28  Daco Harkes  [native_assets_builder] Only build native assets for dependencies of requested package (#833)
  f1221814  2023-11-28  Daco Harkes  [ffigen][infra] Use Apple silicon on CI (#832)

source_span (https://github.com/dart-lang/source_span/compare/ed16e0d..9398e24):
  9398e24  2023-11-29  Kevin Moore  Move to latest lints, require Dart 3.1 (#106)

stack_trace (https://github.com/dart-lang/stack_trace/compare/6496ff8..4abff44):
  4abff44  2023-11-29  Kevin Moore  Latest lints, require Dart ^3.1 (#146)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/c417cbb..59ce97f):
  59ce97f  2023-11-29  Kevin Moore  Bump and fix latest lints, require Dart 3.1 (#60)

test_process (https://github.com/dart-lang/test_process/compare/c21e40d..d68de5b):
  d68de5b  2023-11-29  Kevin Moore  Update lints, require Dart ^3.1 (#52)

vector_math (https://github.com/google/vector_math.dart/compare/e4066cc..cca3cf1):
  cca3cf1  2023-11-27  Devon Carew  Update README.md (#308)

web (https://github.com/dart-lang/web/compare/fdfbaef..cffc2e3):
  cffc2e3  2023-11-30  Devon Carew  parse spec info for generated libraries (#111)
  d902401  2023-11-29  Devon Carew  update the readme (#110)
  e5be5b3  2023-11-28  Devon Carew  delete previously generated files when generating (#108)

webdev (https://github.com/dart-lang/webdev/compare/6961b20..63e09e5):
  63e09e50  2023-11-30  Elliott Brooks  Remove unused scripting code and permission (#2294)
  8c225550  2023-11-29  Elliott Brooks  Prepare Dart Debug Extension for MV3 release (#2293)
  3bb4a6a6  2023-11-28  Elliott Brooks  Remove old code from before the new Dart Debug Extension (#2290)

Change-Id: Ia219625dce03494620a73272e8d1bde03e2e8aea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339222
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants