New issue

Jump to bottom

dartc build failure: private DartNode.setParent() #10

Closed

DartBot opened this issue Oct 10, 2011 · 7 comments

DartBot commented Oct 10, 2011

This issue was originally filed by [email protected]

What steps will reproduce the problem?

build dart compiler

What is the expected output? What do you see instead?
dart/compiler/java/com/google/dart/compiler/ast/DartNode.java fails to compile with the following error:
    [javac] /data/down/devel/dart/dart/compiler/java/com/google/dart/compiler/ast/DartNode.java:122: error: setParent(DartNode) has private access in DartNode
    [javac] child.setParent(this);
    [javac] ^

What version of the product are you using? On what operating system?
dart svn, javac 1.7.0 on arch linux

Please provide any additional information below.
Making setParent() protected instead of private fixes the issue for me, allowing it to be called from protected method becomeParentOf() of the same class.

Contributor

dgrove commented Oct 11, 2011

Added Area-Compiler label.

Author

DartBot commented Oct 11, 2011

This comment was originally written by [email protected]

Set owner to [email protected].

Author

DartBot commented Oct 11, 2011

This comment was originally written by [email protected]

Added Accepted label.

Author

DartBot commented Oct 12, 2011

This comment was originally written by [email protected]

the correct way to fix it is to write:
((DartNode)child).setParent(this);

It's avoid to change the visibility of setParent.

Author

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]

Should be fixed at r471

Set owner to [email protected].

Author

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]

The fix works for me.

Author

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]

Added Fixed label.

DartBot added Type-Defect labels

DartBot mentioned this issue

v8 compilation fixes for f16 (gcc 4.6.1) #43

Closed

kodandersson mentioned this issue

VM crash when profiler thread-unsafely accesses stub code entry #23702

Closed

This was referenced Jul 15, 2015

VM crashes on shutdown #23844

Closed

full_coverage_test is flaky on Windows and Linux #23848

Closed

turnidge mentioned this issue

Investigate code_test.dart on windows: Invalid radix-10 number #24038

Closed

curtis-robert mentioned this issue

Dart2JS Compiler Crash Error #24057

Closed

fsc8000 mentioned this issue

VM: Failing (flaky) service test service/smart_next_test #24221

Closed

This was referenced Aug 28, 2015

Flaky assertion failure in service/pause_on_start_then_step_test #24230

Closed

Service Test flaky with runtime/vm/thread.cc:157: error: expected: !isolate->HasMutatorThread() #24224

Closed

This was referenced Sep 2, 2015

InterfaceTypeSuggestionBuilder exception #24270

Closed

NonExistingSource exception during sendAnalysisNotificationNavigation #24272

Closed

iposva-google mentioned this issue

_methodNameFromUri gets bad Uri #24388

Closed

zoechi mentioned this issue

Dartium bleeding edge exception #24494

Closed

danrubel mentioned this issue

LocalReferenceContributor exception #24509

Closed

scheglov mentioned this issue

Exception in completion #24630

Closed

rmacnak-google mentioned this issue

Precompilation: crash on language/issue21159_test.dart on simulators #24659

Closed

danrubel mentioned this issue

RangeError in local reference contributor #24718

Closed

whesse mentioned this issue

Pub test is failing on dev channel #24825

Closed

bwilkerson mentioned this issue

Exceptions during constant evaluation and validation #24863

Closed

mnts mentioned this issue

app crashes once staps on breakpoints #54838

Open

itsjustkevin mentioned this issue

[Dart2Wasm] Error root cause is obscured by stacktrace #55033

Open

JgomesAT mentioned this issue

Internal Error MapStyler #55039

Closed

bvversoz mentioned this issue

Target dart2js failed: ProcessException: Process exited abnormally with exit code 253: Internal Error: The compiler crashed when compiling this element. The compiler is broken. #55096

Open

adityasaxen mentioned this issue

The analysis server shut down unexpectedly #55193

Closed

upasana-khatiwada mentioned this issue

cannot run any flutter command #55212

Closed

Reinoal mentioned this issue

Invocation: 'dart pub get --no-example' Exception: 'type 'Null' is not a subtype of type 'int' in type cast' #55221

Closed

butterbrain mentioned this issue

Crash in Dart Compiler share_plus-8.0.2/lib/src/share_plus_web.dart:316:20 #55379

Closed

abhisiroha mentioned this issue

Compilation Error during web publishing #55563

Closed

eernstg mentioned this issue

The analyzer encounters an unhandled exception during constant verification in a switch statement #56117

Open

Lootwig mentioned this issue

Analyzer exception doesn't specify affected file #56281

Open

the-mrinal mentioned this issue

Target dart2js failed: ProcessException: Process exited abnormally with exit code 253: ../../../.pub-cache/hosted/pub.dev/share_plus-9.0.0/lib/src/share_plus_web.dart:264:20: Internal Error: Unknown external method j:method(ShareData|constructor#files) external factory ShareData.files({ #56354

Open

aam mentioned this issue

Bug Causing Dart.exe to Eat Up All Available Memory. #56355

Closed

ailabs-software mentioned this issue

webdev error after upgrading to Dart 3.5.0 #56382

Closed

thermoworker mentioned this issue

Internal error: Exception while using a AvoidRedundantArgumentValues to visit... #56448

Closed

theaquaflower mentioned this issue

Exception from yaml parsing during dart fix #56473

Closed

724898928 mentioned this issue

dart ffi: error code 126 #51659

Open

SwederSchellens mentioned this issue

dart2js crashes in pkg:kernel #56773

Closed

mjablecnik mentioned this issue

Dart analysis issue. Missing library: dart:async #56798

Open

ChaserVasya mentioned this issue

Internal error: Bad state: Expected existing element #56922

Open

MohammadNezarAldalati mentioned this issue

Improve diagnostic reporting on invalid analysis options #56943

Open

MLDenzzl mentioned this issue

Error while processing the analysis.setAnalysisRoots request #56429

Closed

antonbashir added a commit to antonbashir/dart that referenced this issue


          Merge pull request 'fibers' (dart-lang#10) from fibers into main

1c652e1

Reviewed-on: http://git.local/dependencies/dart/pulls/10

neoapps-dev mentioned this issue

Doesn't work with Huggingface docker hosting #59630

Closed

thermoworker mentioned this issue

An unexpected error was encountered by the Analysis Server - null #59756

Open

hasimyerlikaya mentioned this issue

Dart Analyzer very slow/stuck #55281

Open

ac-arconomy mentioned this issue

The compiler is broken #59870

Closed

Kaushik-Mandale mentioned this issue

Unexpected Version of kernel sdk #60057

Closed

NiclasLeichsenring mentioned this issue

[Dart-Analysis] Internal error: type 'LibraryElementImpl' is not a subtype of type 'Fragment' in type cast #60168

Closed

copybara-service bot pushed a commit that referenced this issue


          [tests] Fix flaky standalone/io/http_auth_digest_test

b2c8b31

This test has a few independent calls to asyncExpectThrows which uses
asyncStart/asyncEnd. However, multiple top-level asyncStart/asyncEnd
are not allowed, which causes the following flaky error:

```
Unhandled exception:
Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test.
#0      asyncStart (package:expect/async_helper.dart:53)
#1      asyncExpectThrows (package:expect/async_helper.dart:140)
#2      testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/tests/standalone/io/http_auth_digest_test.dart:345)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951)
#4      Future._propagateToListeners (dart:async/future_impl.dart:980)
#5      Future._completeWithValue (dart:async/future_impl.dart:723)
#6      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:40)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:128)
#10     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:195)

--- Re-run this test:
python3 tools/test.py -n vm-aot-ubsan-linux-release-x64 standalone/io/http_auth_digest_test
```

This change attempts to fix this by adding a top-level asyncStart/asyncEnd
and also asyncStart/asyncEnd to the server start/shutdown to
enclose each test case into asyncStart/asyncEnd and avoid printing
"unittest-suite-success" marker before all test cases are finished.

TEST=standalone/io/http_auth_digest_test

Change-Id: I950e7c6c09f5c2144da874ab3be3cd3a130d3790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411086
Commit-Queue: Alexander Markov <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment