Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables in single/double quotes. #5

Closed
DartBot opened this issue Oct 10, 2011 · 1 comment
Closed

Variables in single/double quotes. #5

DartBot opened this issue Oct 10, 2011 · 1 comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented Oct 10, 2011

This issue was originally filed by [email protected]

Can we use the PHP view that single quotes don't contain variables, but double quotes do... this may help the parser in speed, but more importantly it means the programmer doesn't have to check for and escape variables in single quoted strings.
@DartBot
Copy link
Author

DartBot commented Oct 10, 2011

This comment was originally written by [email protected]

Dart already has raw strings: @­"This $foo isn't interpolated".

Added WontFix label.

@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@blois blois mentioned this issue Jun 3, 2015
Closed
@sgjesse sgjesse mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
Closed
Closed
@sgjesse sgjesse mentioned this issue Jun 3, 2015
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
@peter-ahe-google peter-ahe-google mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@lrhn lrhn mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@floitschG floitschG mentioned this issue Jun 3, 2015
Closed
@stereotype441 stereotype441 mentioned this issue Jun 3, 2015
Closed
@whesse whesse mentioned this issue Jun 3, 2015
Closed
@iposva-google iposva-google mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@anders-sandholm anders-sandholm mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
@cosminbodnariuc cosminbodnariuc mentioned this issue Dec 7, 2023
Closed
@derekxu16 derekxu16 mentioned this issue Dec 18, 2023
Closed
@aam aam mentioned this issue Jan 22, 2024
Closed
@mnts mnts mentioned this issue Feb 6, 2024
Open
@itsjustkevin itsjustkevin mentioned this issue Feb 27, 2024
Open
@JgomesAT JgomesAT mentioned this issue Feb 28, 2024
Closed
@bvversoz bvversoz mentioned this issue Mar 5, 2024
Open
@adityasaxen adityasaxen mentioned this issue Mar 14, 2024
Closed
@upasana-khatiwada upasana-khatiwada mentioned this issue Mar 16, 2024
Closed
@Reinoal Reinoal mentioned this issue Mar 18, 2024
Closed
@butterbrain butterbrain mentioned this issue Apr 4, 2024
Closed
@scheglov scheglov mentioned this issue Apr 11, 2024
Closed
@abhisiroha abhisiroha mentioned this issue Apr 24, 2024
Closed
@eernstg eernstg mentioned this issue Jul 1, 2024
Open
@majornuts majornuts mentioned this issue Jul 4, 2024
Closed
@Lootwig Lootwig mentioned this issue Jul 18, 2024
Open
@the-mrinal the-mrinal mentioned this issue Jul 31, 2024
Open
@aam aam mentioned this issue Jul 31, 2024
Closed
@ailabs-software ailabs-software mentioned this issue Aug 6, 2024
Closed
@thermoworker thermoworker mentioned this issue Aug 12, 2024
Open
@theaquaflower theaquaflower mentioned this issue Aug 15, 2024
Closed
@724898928 724898928 mentioned this issue Sep 4, 2024
Open
@SwederSchellens SwederSchellens mentioned this issue Sep 24, 2024
Closed
@mjablecnik mjablecnik mentioned this issue Sep 27, 2024
Open
@ChaserVasya ChaserVasya mentioned this issue Oct 20, 2024
Open
copybara-service bot pushed a commit that referenced this issue Oct 22, 2024
@pq
[element model] fix unsafe ConstructorMember cast
f65f719 
See: b/374689139.

https://dart-review.googlesource.com/c/sdk/+/390941 is blocking an SDK roll.

Root cause:


```
Action threw an exception: type 'ConstructorMember' is not a subtype of type 'ConstructorFragment' in type cast
#0      InterfaceTypeImpl.constructors2.<anonymous closure> (package:analyzer/src/dart/element/type.dart:569)
#1      MappedListIterable.elementAt (dart:_internal/iterable.dart:435)
#2      ListIterator.moveNext (dart:_internal/iterable.dart:364)
#3      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:150)
#5      new List.of (dart:core-patch/array_patch.dart:39)
#6      ListIterable.toList (dart:_internal/iterable.dart:224)
#7      InterfaceTypeImpl.constructors2 (package:analyzer/src/dart/element/type.dart:570)
#8      _Visitor._hasConstConstructorInvocation (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:110)
#9      _Visitor.visitConstructorDeclaration (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:58)
```


To verify the fix locally:

```
  solo_test_X() async {
    await assertNoErrorsInCode(r'''
class A<T> {}
''');

    var A = findElement.class_('A').instantiate(
      typeArguments: [intType],
      nullabilitySuffix: NullabilitySuffix.none,
    );
    A.constructors2;
  }
```


Bug: b/374689139
Change-Id: I70034d938d840dc0c3939db27e7116164e4617e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391483
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Open
@MLDenzzl MLDenzzl mentioned this issue Oct 28, 2024
Closed
antonbashir added a commit to antonbashir/dart that referenced this issue Nov 21, 2024
@antonbashir
Merge pull request 'Fibers dart-lang#5' (dart-lang#4) from fibers int…
81b3c13 
…o main

Reviewed-on: http://git.local/dependencies/dart/pulls/4
@neoapps-dev neoapps-dev mentioned this issue Nov 28, 2024
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @DartBot