Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version number to snapshots #15982

Closed
iposva-google opened this issue Jan 9, 2014 · 6 comments
Closed

Add a version number to snapshots #15982

iposva-google opened this issue Jan 9, 2014 · 6 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@iposva-google
Copy link
Contributor

Every time the internal data structures in the VM change we need to invalidate existing snapshots as they are now incompatible.

A simple approach could be to bump the version number for every single official build.

More accurate, but significantly more involved would be to increase the version number whenever the information recorded in the snapshot changes. For example, generate a hash based on the VM internal data structures and core libraries flowing into the snapshot.

@iposva-google
Copy link
Contributor Author

Set owner to @a-siva.
Added Accepted label.

@fsc8000
Copy link
Contributor

fsc8000 commented Aug 13, 2014

Issue #20485 has been merged into this issue.

@nex3
Copy link
Member

nex3 commented Aug 13, 2014

For context from issue #20485, this is important for supporting issue #20482 and issue #20483. Can we bump up the priority at all?

@iposva-google
Copy link
Contributor Author

We'll make sure Zach has some time to work on this.

We might start with being overly conservative: Meaning snapshots will NOT be compatible across builds even if the format has not necessarily changed.


cc @a-siva.
Set owner to @zanderso.
Added this to the 1.7 milestone.
Removed Priority-Unassigned label.
Added Priority-High label.

@zanderso
Copy link
Member

Added Started label.

@a-siva
Copy link
Contributor

a-siva commented Aug 27, 2014

@iposva-google iposva-google added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Aug 27, 2014
@iposva-google iposva-google added this to the 1.7 milestone Aug 27, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

5 participants