Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup calls to runtime (pushing raw_null for return value) #995

Closed
iposva-google opened this issue Dec 27, 2011 · 1 comment
Closed

Cleanup calls to runtime (pushing raw_null for return value) #995

iposva-google opened this issue Dec 27, 2011 · 1 comment
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@iposva-google
Copy link
Contributor

Where appropriate we should standardize on using

__ pushl(raw_null); // pushq on x64

to make space for the return value when calling into the runtime from generated code.
@a-siva
Copy link
Contributor

a-siva commented Dec 28, 2011

http://codereview.chromium.org//8965071

Added Fixed label.

@iposva-google iposva-google added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Dec 28, 2011
dart-bot pushed a commit that referenced this issue Mar 17, 2021
@athomas
[co19] Roll co19 to 8cf837f5abf0a30ed91ebf480df58e5c0480947e
5a81552 
2021-03-17 [email protected] Fixes #1017. Use => for setter returning value tests
2021-03-16 [email protected] Issue #996: more tests for Generic functions as type arguments and bounds added.
2021-03-16 [email protected] Fixes #1005. Description updated for method_definition tests
2021-03-16 [email protected] Fixes #1011. Expect an error if non-function type is called as a function
2021-03-16 [email protected] Issue #996: tests for Generic functions as type arguments and bounds re-factored, more tests added.
2021-03-15 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 [email protected] Missed experiment flag added
2021-03-12 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-12 [email protected] #993. Added tests checking that Struct fields cannot have initializers
2021-03-12 [email protected] #993. Tests for not external members of Struct subtype added
2021-03-11 [email protected] #993. Use package ffi in co19 ffi tests
2021-03-09 [email protected] Fixes #995. Annotations with type arguments tests added
2021-03-09 [email protected] Issue #997: existing triple-shift tests corrected.
2021-03-09 [email protected] More fixes for #535: split constant evaluation tests because static behavior of the strong and weak mode is different.
2021-03-04 [email protected] #993. Array tests added
2021-03-04 [email protected] #993. Pointer equality tests added
2021-03-03 [email protected] #993. Pointer.elementAt() tests added
2021-03-02 [email protected] #993. Pointer.cast() tests added
2021-03-01 [email protected] #993. Pointer tests added
2021-03-01 [email protected] Fixes #936. Change expected result according to the new left top rule
2021-02-26 [email protected] Fixed #998: tests checks output streams correctly now.
2021-02-26 [email protected] #993. IntPtr tests added
2021-02-26 [email protected] #993. More Struct tests added
2021-02-25 [email protected] Tests updated, missing issue tags added.
2021-02-25 [email protected] #1003. Isolate test fixed to not to be a racy
2021-02-25 [email protected] Issue numbers added
2021-02-24 [email protected] Issue number added
2021-02-24 [email protected] #988. Typo in error message fixed
2021-02-24 [email protected] #988. Fix test expectations

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I718644028b1d2a9fbba0c7efdf2923bb67184fde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191409
Reviewed-by: William Hesse <[email protected]>
copybara-service bot pushed a commit that referenced this issue Aug 7, 2023
@devoncarew
[deps] rev ecosystem, http, mockito, native, protobuf, shelf, sse, te…
1b1c62a 
…st, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/97fc1a7..dfeda1a):
  dfeda1a  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.0.4 to 4.3.0 (#148)
  c341051  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#147)
  c1c8d1f  2023-08-01  Moritz  Update health.yaml (#146)
  31c5d21  2023-07-27  Devon Carew  misc updates to the label management tool (#145)

http (https://github.com/dart-lang/http/compare/4289e8b..7e9ed12):
  7e9ed12  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#1000)
  e8e35db  2023-07-31  Alex James  [java_http] send request body (#995)

mockito (https://github.com/dart-lang/mockito/compare/b421775..ff79de6):
  ff79de6  2023-08-04  Nate Bosch  Allow the latest package:analyzer

native (https://github.com/dart-lang/native/compare/f0dc3e9..0187d0e):
  0187d0e  2023-08-07  Daco Harkes  [native_assets_cli] Rename `Asset` `name` to `id` (#113)
  1b984c7  2023-08-07  Daco Harkes  [native_assets_cli] Replace `TypeError`s with `FormatException`s (#112)
  b2b26db  2023-08-07  Daco Harkes  [native_assets_builder] Stop throwing from BuildRunner (#108)
  c940ac8  2023-08-03  Daco Harkes  [native_assets_builder] return build dependencies (#107)
  63daab8  2023-08-03  Daco Harkes  [native_assets_builder] Fix dry run directory structure (#110)
  3f26f20  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#104)

protobuf (https://github.com/dart-lang/protobuf/compare/d9e8a31..217c030):
  217c030  2023-08-02  Ömer Sinan Ağacan  Avoid holding onto the buffer when parsing unknown length-delimited fields (#863)

shelf (https://github.com/dart-lang/shelf/compare/bd59ead..73edd2b):
  73edd2b  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#370)

sse (https://github.com/dart-lang/sse/compare/e241085..8cc5b11):
  8cc5b11  2023-08-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.0.0 to 2.1.1 (#86)

test (https://github.com/dart-lang/test/compare/92eb0f7..5d571d6):
  5d571d64  2023-08-03  Nate Bosch  Add --fail-fast flag (#2040)
  a9dcce29  2023-08-01  Nate Bosch  Rerun publish workflow on more PR changes (#2070)
  50d558b2  2023-08-01  dependabot[bot]  Bump github/codeql-action from 2.20.1 to 2.21.2 (#2071)
  9e124e9f  2023-07-31  Nate Bosch  Prepare to publish (#2069)

tools (https://github.com/dart-lang/tools/compare/af3fc99..f14bf2e):
  f14bf2e  2023-08-07  Elias Yishak  Remove unused NoOp classes (#138)
  a2aa1c3  2023-08-07  Devon Carew  add CI; update readme (#140)
  d424568  2023-08-06  Devon Carew  add usage docs to package:cli_config (#141)
  921611a  2023-08-03  Elias Yishak  Survey handler feature (#109)

Change-Id: Iee720272733822d11caf46adcae516f12f11abec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318801
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iposva-google @a-siva